Summary

Implement get_all_local_ips for windows

Review Request #2048 — Created Nov. 8, 2022 and submitted Nov. 9, 2022, 4:16 a.m.

Owner

grim

Repository

traversity/traversity

Branch

default

Bugs

Depends On

Groups

People

Description

This is a simple approach and only works with IPv4 In the meantime this seems to work for simple cases.

Testing Done

Ran on Windows 11 and verified it got the correct IP address.

Commits

Summary	ID
Implement get_all_local_ips for windows This is a simple approach and may only work with IPv4, but we need more testing to confirm. In the meantime though, this seems to work for simple cases.	757085a6e9abb59b7a041082a96efdc251459fa9

Issues

Description	From	Last Updated
I would move the strdup into the if: ips = g_list_prepend(ips, g_strdup(ip))	QuLogic	Nov. 9, 2022, 3:49 a.m.

Change Summary:

use g_networking_init instead of manually setting up winsock

Commits:

	Summary	ID
	Implement get_all_local_ips for windows This is a simple approach and may only work with IPv4, but we need more testing to confirm. In the meantime though, this seems to work for simple cases.	83bc42043c9e38e50b81c583ec6b71b2777a6c22
	Implement get_all_local_ips for windows This is a simple approach and may only work with IPv4, but we need more testing to confirm. In the meantime though, this seems to work for simple cases.	767c47ead45398984f002beb91c3322f6b6ae304

Diff:

	traversity/meson.build
	traversity/traversitycore.c
	traversity/traversitycorewin32.c
	traversity-test/traversity-test.c

traversity/traversitycorewin32.c (Diff revision 2)

The issue has been resolved. Show all issues

I would move the strdup into the if: ips = g_list_prepend(ips, g_strdup(ip))

Change Summary:

address issues

Commits:

	Summary	ID
	Implement get_all_local_ips for windows This is a simple approach and may only work with IPv4, but we need more testing to confirm. In the meantime though, this seems to work for simple cases.	767c47ead45398984f002beb91c3322f6b6ae304
	Implement get_all_local_ips for windows This is a simple approach and may only work with IPv4, but we need more testing to confirm. In the meantime though, this seems to work for simple cases.	757085a6e9abb59b7a041082a96efdc251459fa9

Diff:

	traversity/meson.build
	traversity/traversitycore.c
	traversity/traversitycorewin32.c
	traversity-test/traversity-test.c

Description:: ~
This is a simple approach and may only work with IPv4, but we need more testing
~
This is a simple approach and only works with IPv4 In the meantime this seems to work for simple cases.
- to confirm. In the meantime though, this seems to work for simple cases.

Ship it!

~		This is a simple approach and may only work with IPv4, but we need more testing
	~	This is a simple approach and only works with IPv4 In the meantime this seems to work for simple cases.
-		to confirm. In the meantime though, this seems to work for simple cases.