Modernize add buddy/chat dialogs

 






 

 


  Review Request #2045
  —
  Created Nov. 8, 2022 and submitted 

 




















 

  

   Information

  





 
 

  QuLogic
 









 
 

  pidgin/pidgin
 









 
 

  default
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
Use AdwEntryRow where possible, add bigger margins/spacing, use some Adwaita styles, and tweak some text.


Like the auto-generated account options, this uses an entry for integer values, instead of the spin button.

 








  


 
 

  
Opened 'Add a Buddy' dialog, and added one.

Opened 'Add a Chat' dialog, and added one, also changed protocols to confirm that the fields changed.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Modernize add buddy/chat dialogs
      
Use AdwEntryRow where possible, add bigger margins/spacing, use some Adwaita
styles, and tweak some text.

     


    		
    673b8b0858c92a2f3b901b70ba26378b88fd29d7

   



  
 




 













 

  
  


   

    

     

     

     

    

   


   

    

     

     

     

    

   


   

    

     

     

     

    

   


   

    

     

     

     

    

   


   

  

 







 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
no defaults for ints?

      		
      
       grimgrim
      
      
       
      
     


    
   

  

 







 






  

 








 














 





 

  

   




grim




   

   







  

 



 

  


   

   

    
 
grim


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       pidgin/pidginaddchatdialog.c
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    no defaults for ints?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I don't know; I didn't find any in-tree PurpleProtocolChatEntry that actually were integers left.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      I don't see anything in existing plugins either, so should be fine, and actually the types could probably just be dropped?
      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      Looking at purple_protocol_chat_info_defaults, the default must be a string, so that's likely the best we can do. I'll just move the lookup later and have it set the entry for ints the same way as strings.
      
 
      

      4. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




QuLogic




   

   

  

 



 















 





 

  

   




grim




   

   







  

 



 

  


   

   

    
 
grim


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 







  2. 
 
    
  
  
    
  
   
    
    
    





    
    Great work, thanks!!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 













  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




grim




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed