Summary

Propagate the PurpleAccount::notify signal via PurpleAccountManager::account-changed

Review Request #2032 — Created Nov. 5, 2022 and submitted Nov. 5, 2022, 4:59 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~2031~~

Reviewers

Groups

pidgin

People

Description

This new signal supports details and works just like notify does on the account
instances, but it will be emitted for any account that the manager instance
knows about which means we can remove the old purple signals.

Testing Done

Enabled and disabled accounts in Pidgin via the menus to make sure things were working right, and verified via the console that the accounts were being enabled and disabled.
Ran Finch, but I ran into the infinite loop bug in the buddy list clean when disabling an account which is a known issue.

Commits

Summary	ID
Propagate the PurpleAccount::notify signal via PurpleAccountManager::account-changed This new signal supports details and works just like notify does on the account instances, but it will be emitted for any account that the manager instance knows about which means we can remove the old purple signals.	fba96a4d56d362f552ac09c6591ca1facfb4ac9b

Issues

Description	From	Last Updated
data is unused now.	QuLogic	Nov. 5, 2022, 4:50 a.m.
when an account's	QuLogic	Nov. 5, 2022, 4:50 a.m.
enabled	QuLogic	Nov. 5, 2022, 4:50 a.m.

finch/gntaccount.c (Diff revision 1)
The issue has been resolved. Show all issues
```
data is unused now.
```
libpurple/purpleaccountmanager.c (Diff revision 1)
The issue has been resolved. Show all issues
```
when an account's
```
pidgin/pidginaccountsenabledmenu.c (Diff revision 1)
The issue has been resolved. Show all issues
```
enabled
```

Change Summary:

Address issues

Commits:

	Summary	ID
	Propagate the PurpleAccount::notify signal via PurpleAccountManager::account-changed This new signal supports details and works just like notify does on the account instances, but it will be emitted for any account that the manager instance knows about which means we can remove the old purple signals.	ff1216a1a59b2efad092d1aca6f004c619b0f9e3
	Propagate the PurpleAccount::notify signal via PurpleAccountManager::account-changed This new signal supports details and works just like notify does on the account instances, but it will be emitted for any account that the manager instance knows about which means we can remove the old purple signals.	fba96a4d56d362f552ac09c6591ca1facfb4ac9b

Depends On:

~~2031 - Add purple_account_manager_get_connected and port libpurple to it~~

Diff:

Revision 2 (+194 -212)

Show changes

	ChangeLog.API
	doc/reference/libpurple/signals_account.md
	finch/gntaccount.c
	libpurple/account.c
	libpurple/accounts.c
	libpurple/purpleaccountmanager.c
	pidgin/pidginaccountsdisabledmenu.c
	pidgin/pidginaccountsenabledmenu.c

Ship it!

```
Ship It!
```

Status:: Completed

finch/gntaccount.c (Diff revision 1)