Port some of gg to libsoup3

 






 

 


  Review Request #2011
  —
  Created Nov. 2, 2022 and submitted 

 




















 

  

   Information

  





 
 

  QuLogic
 









 
 

  pidgin/pidgin
 









 
 

  default
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
This does not do the file transfer stuff as I'm not entirely sure of the flow yet, and also don't know how best to do libsoup3 for streaming uploads.


I did add a cancellable to the file transfer code though, to be used later.

 








  


 
 

  
Compiled with soup2 and with soup3.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     
Port gg to libsoup3


    		
    580515195dd7437bdad24db4fc9cc32979d0e8cb

   



  
 




 













 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
where does msg get unreffed here.. I don't see it, but maybe it's magically happening in the background?

      		
      
       grimgrim
      
      
       
      
     


    
   

  

 







 






  

 








 














 





 

  

   




grim




   

   







  

 



 

  


   

   

    
 
grim


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       libpurple/protocols/gg/pubdir-prpl.c
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    where does msg get unreffed here.. I don't see it, but maybe it's magically happening in the background?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Good point; the libsoup2 session took ownership of msg and presumably lasted until the callback. The libsoup3 session doesn't, so I think I must have been leaking them in my previous changes.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      Fixed the existing code in /r/2017.
      
 
      

      3. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




QuLogic




   

   

  

 



 















 





 

  

   




grim




   

   







  

 



 

  


   

   

    
 
grim


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 







  2. 
 
    
  
  
    
  
   
    
    
    





    
    Great work, thanks!!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 













  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




grim




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed