Summary

Implement traversity_core_get_local_ips for UNIX systems

Review Request #1963 — Created Oct. 25, 2022 and submitted Nov. 8, 2022, 4:04 a.m.

Information

Owner

grim

Repository

traversity/traversity

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This is basically an import from the original code in purple2 with some clean
ups.

Testing Done

ran traversity-test on Debian Bookworm AMD64, OpenBSD 7.1 64bit, Freebsd 13.1 32bit, macOS Monterey 64bit, and Haiku OS (not sure version/arch).

I also force the ioctl path on all of them, Haiku only uses the ioctl path, but OpenBSD does not support the ioctl path.

Commits

Summary	ID
Implement traversity_core_get_local_ips for UNIX systems This is basically an import from the original code in purple2 with some clean ups.	208a31ff2c5986cc9e192683f36afb15d29f7e93

Issues

Description	From	Last Updated
Should we add some error information to error here in case of tmp being NULL? inet_ntop sets errno.	ivanhoe	Nov. 2, 2022, 7:55 p.m.
freeifaddrs is not called in case if this early return.	ivanhoe	Nov. 7, 2022, 4:55 p.m.
Should we use error to collect possible errors from socket, ioctl, and inet_ntop?	ivanhoe	Nov. 2, 2022, 7:55 p.m.
Is this a typo or some special version of ioctl that returns the error code? Judging from the Linux man …	ivanhoe	Nov. 7, 2022, 4:56 p.m.
Should free ifc.ifc_req in case of this early return.	ivanhoe	Nov. 7, 2022, 4:56 p.m.
Should free ifc.ifc_req in case of this early return.	ivanhoe	Nov. 7, 2022, 4:56 p.m.
I think the G_GNUC_UNUSED can be removed now.	ivanhoe	Nov. 7, 2022, 4:57 p.m.
Same as above, is it correct to use ret here instead of errno?	ivanhoe	Nov. 7, 2022, 4:57 p.m.

Testing Done:: ~
ran traversity-test on linux (Debian Bookworm AMD64), OpenBSD 7.1 64bit, Freebsd 13.1 32bit, macOS Monterey 64bit, and Haiku OS (not sure version/arch).
~
ran traversity-test on Debian Bookworm AMD64, OpenBSD 7.1 64bit, Freebsd 13.1 32bit, macOS Monterey 64bit, and Haiku OS (not sure version/arch).

I also force the ioctl path on all of them, Haiku only uses the ioctl path, but OpenBSD does not support the ioctl path.

traversity/traversitycoreunix.c (Diff revision 1)

The issue has been resolved. Show all issues

Should we add some error information to error here in case of tmp being NULL? inet_ntop sets errno.

traversity/traversitycoreunix.c (Diff revision 1)

The issue has been resolved. Show all issues

Should we use error to collect possible errors from socket, ioctl, and inet_ntop?

traversity/traversitycoreunix.c (Diff revision 1)

The man page of netdevice suggests the following regarding the size of buffer:
If  the  size  specified by ifc_len is insufficient to store all the addresses, the kernel will skip the exceeding ones and return success.  There is no reliable way of detecting this condition once it has occurred.  It is therefore recommended to either determine the necessary buffer size beforehand by calling SIOCGIFCONF with ifc_req set to NULL, or to retry the call with a bigger buffer whenever ifc_len upon return differs by less than sizeof(struct ifreq) from its original value.

Change Summary:

address issues

Commits:

	Summary	ID
	Implement traversity_core_get_local_ips for UNIX systems This is basically an import from the original code in purple2 with some clean ups.	b19bfb19bf5e9fa892262a097ca6cb7743f9c82f
	Implement traversity_core_get_local_ips for UNIX systems This is basically an import from the original code in purple2 with some clean ups.	4d54fd2002e8d5b564d89094786facf51bb7b517

Diff:

Revision 2 (+554 -30)

Show changes

	meson.build
	traversity/meson.build
	traversity/traversitycore.h
	traversity/traversitycoreunix.c
	traversity-test/traversity-test.c

Change Summary:

special case haiku as it doesn't support calling SIOCGIFCONF with a NULL parameter to get the buffer size.

Commits:

	Summary	ID
	Implement traversity_core_get_local_ips for UNIX systems This is basically an import from the original code in purple2 with some clean ups.	4d54fd2002e8d5b564d89094786facf51bb7b517
	Implement traversity_core_get_local_ips for UNIX systems This is basically an import from the original code in purple2 with some clean ups.	9ca25f34c40b66838b542dac2ee4b1ca6e38292f

Diff:

Revision 3 (+712 -30)

Show changes

	meson.build
	traversity/meson.build
	traversity/traversitycore.h
	traversity/traversitycoreunix.c
	traversity-test/traversity-test.c

Change Summary:

fix typo

Commits:

	Summary	ID
	Implement traversity_core_get_local_ips for UNIX systems This is basically an import from the original code in purple2 with some clean ups.	9ca25f34c40b66838b542dac2ee4b1ca6e38292f
	Implement traversity_core_get_local_ips for UNIX systems This is basically an import from the original code in purple2 with some clean ups.	9b0f18986dc12744cee8fac52d523681729e3312

Diff:

Revision 4 (+712 -30)

Show changes

	meson.build
	traversity/meson.build
	traversity/traversitycore.h
	traversity/traversitycoreunix.c
	traversity-test/traversity-test.c

traversity/traversitycoreunix.c (Diff revisions 1 - 4)
The issue has been resolved. Show all issues
```
freeifaddrs is not called in case if this early return.
```

traversity/traversitycoreunix.c (Diff revisions 1 - 4)

The issue has been resolved. Show all issues

Is this a typo or some special version of ioctl that returns the error code? Judging from the Linux man page of ioctl this should be g_strerror(errno). Same issue on line 161.

traversity/traversitycoreunix.c (Diff revisions 1 - 4)
The issue has been resolved. Show all issues
```
Should free ifc.ifc_req in case of this early return.
```
traversity/traversitycoreunix.c (Diff revisions 1 - 4)
The issue has been resolved. Show all issues
```
Should free ifc.ifc_req in case of this early return.
```
traversity/traversitycoreunix.c (Diff revisions 1 - 4)
The issue has been resolved. Show all issues
```
I think the G_GNUC_UNUSED can be removed now.
```
traversity/traversitycoreunix.c (Diff revisions 1 - 4)
The issue has been resolved. Show all issues
```
Same as above, is it correct to use ret here instead of errno?
```

Change Summary:

address issues

Commits:

	Summary	ID
	Implement traversity_core_get_local_ips for UNIX systems This is basically an import from the original code in purple2 with some clean ups.	9b0f18986dc12744cee8fac52d523681729e3312
	Implement traversity_core_get_local_ips for UNIX systems This is basically an import from the original code in purple2 with some clean ups.	208a31ff2c5986cc9e192683f36afb15d29f7e93

Diff:

Revision 5 (+724 -30)

Show changes

	meson.build
	traversity/meson.build
	traversity/traversitycore.h
	traversity/traversitycoreunix.c
	traversity-test/traversity-test.c

Ship it!

```
Ship It!
```

Status:: Completed

~		ran traversity-test on linux (Debian Bookworm AMD64), OpenBSD 7.1 64bit, Freebsd 13.1 32bit, macOS Monterey 64bit, and Haiku OS (not sure version/arch).
	~	ran traversity-test on Debian Bookworm AMD64, OpenBSD 7.1 64bit, Freebsd 13.1 32bit, macOS Monterey 64bit, and Haiku OS (not sure version/arch).

		I also force the ioctl path on all of them, Haiku only uses the ioctl path, but OpenBSD does not support the ioctl path.