Summary

Add support for handling PRIVMSG and NOTICE messages from the server

Review Request #1932 — Created Oct. 13, 2022 and submitted Oct. 14, 2022, 2:12 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This is a very naive approach as we skip a lot of details including converting
the source into just a nick, but we will iterate on this for those features
later.

Testing Done

Connected to a local ergo instance and sent privmsg and notices to the account from a pidgin2 irc account.

Commits

Summary	ID
Add support for handling PRIVMSG and NOTICE messages from the server This is a very naive approach as we skip a lot of details including converting the source into just a nick, but we will iterate on this for those features later.	c86eb0be23ab2f484277e11a82fde7bf12cd46ca

Issues

Description	From	Last Updated
params[0][0] or possibly you may want a variable target = params[0].	QuLogic	Oct. 14, 2022, 2:08 a.m.
Would still do this as target[0] as well.	QuLogic	Oct. 14, 2022, 2:09 a.m.
guint64, not guint, but actually you can pass 0 to get 'now' without creating a GDateTime here.	QuLogic	Oct. 14, 2022, 2:08 a.m.

libpurple/protocols/ircv3/purpleircv3messagehandlers.c (Diff revision 1)
The issue has been resolved. Show all issues
```
params[0][0] or possibly you may want a variable target = params[0].
```
libpurple/protocols/ircv3/purpleircv3messagehandlers.c (Diff revision 1)
The issue has been resolved. Show all issues
```
guint64, not guint, but actually you can pass 0 to get 'now' without creating a GDateTime here.
```

Change Summary:

address issues

Commits:

	Summary	ID
	Add support for handling PRIVMSG and NOTICE messages from the server This is a very naive approach as we skip a lot of details including converting the source into just a nick, but we will iterate on this for those features later.	bde4ca14af1637233fb3436efaf182fd2d32353b
	Add support for handling PRIVMSG and NOTICE messages from the server This is a very naive approach as we skip a lot of details including converting the source into just a nick, but we will iterate on this for those features later.	8a2e7645b4307791b82f0167ca091de64b50d56d

Diff:

Revision 2 (+154 -4)

Show changes

	libpurple/protocols/ircv3/purpleircv3messagehandlers.h
	libpurple/protocols/ircv3/purpleircv3messagehandlers.c
	libpurple/protocols/ircv3/purpleircv3parser.c

Ship it!

```
Ship It!
```
libpurple/protocols/ircv3/purpleircv3messagehandlers.c (Diff revisions 1 - 2)
The issue has been resolved. Show all issues
```
Would still do this as target[0] as well.
```

Change Summary:

change the way we deref target to check if the first byte is a '#' to stay consistent with the other dereferences.

Commits:

	Summary	ID
	Add support for handling PRIVMSG and NOTICE messages from the server This is a very naive approach as we skip a lot of details including converting the source into just a nick, but we will iterate on this for those features later.	8a2e7645b4307791b82f0167ca091de64b50d56d
	Add support for handling PRIVMSG and NOTICE messages from the server This is a very naive approach as we skip a lot of details including converting the source into just a nick, but we will iterate on this for those features later.	c86eb0be23ab2f484277e11a82fde7bf12cd46ca

Diff:

Revision 3 (+154 -4)

Show changes

	libpurple/protocols/ircv3/purpleircv3messagehandlers.h
	libpurple/protocols/ircv3/purpleircv3messagehandlers.c
	libpurple/protocols/ircv3/purpleircv3parser.c

Status:: Completed