Summary

Remember CredentialProvider setting while exiting

Review Request #1918 — Created Oct. 10, 2022 and submitted Oct. 10, 2022, 5:27 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

We were resetting the setting to its default if we had a NULL active provider
id. However, the only time it's valid to call
purple_credential_manager_set_active_provider with a NULL id is during shutdown.

If someone is trying to disable all credential providers, they will be selecting
the noop provider which has a non null id.

Testing Done

Ran and set the credential provider to libsecret. Closed the program, reopened, verified that libsecret was still selected.

Commits

Summary	ID
Remember CredentialProvider setting while exiting We were resetting the setting to it's default if we had a NULL active provider id. However, the only time it's valid to call purple_credential_manager_set_active_provider with a NULL id is during shutdown. If someone is trying to disable all credential providers, they will be selecting the noop provider which has a non null id.	2f0b6e411da968f369841af90bbbc815bd03fbe1

Issues

Description	From	Last Updated
Getting and unrefing the settings object can go in the if now.	QuLogic	Oct. 10, 2022, 5:16 a.m.

Description:: ~
We were resetting the setting to it's default if we had a NULL active provider
~
We were resetting the setting to its default if we had a NULL active provider
id. However, the only time it's valid to call
purple_credential_manager_set_active_provider with a NULL id is during shutdown.

If someone is trying to disable all credential providers, they will be selecting
the noop provider which has a non null id.

libpurple/purplecredentialmanager.c (Diff revision 1)

The issue has been resolved. Show all issues

Getting and unrefing the settings object can go in the if now.

Change Summary:

move all of the settings stuff into the conditional

Commits:

	Summary	ID
	Remember CredentialProvider setting while exiting We were resetting the setting to it's default if we had a NULL active provider id. However, the only time it's valid to call purple_credential_manager_set_active_provider with a NULL id is during shutdown. If someone is trying to disable all credential providers, they will be selecting the noop provider which has a non null id.	4bfa6d23cc71a688e18f39eacdec2abf48813169
	Remember CredentialProvider setting while exiting We were resetting the setting to it's default if we had a NULL active provider id. However, the only time it's valid to call purple_credential_manager_set_active_provider with a NULL id is during shutdown. If someone is trying to disable all credential providers, they will be selecting the noop provider which has a non null id.	2f0b6e411da968f369841af90bbbc815bd03fbe1

Diff:

Revision 2 (+28 -12)

Show changes

	libpurple/purplecredentialmanager.h
	libpurple/purplecredentialmanager.c

Ship it!

```
Ship It!
```

Status:: Completed

~		We were resetting the setting to it's default if we had a NULL active provider
	~	We were resetting the setting to its default if we had a NULL active provider
		id. However, the only time it's valid to call
		purple_credential_manager_set_active_provider with a NULL id is during shutdown.

		If someone is trying to disable all credential providers, they will be selecting
		the noop provider which has a non null id.