Summary

Add connection registration to the IRCv3 protocol plugin

Review Request #1898 — Created Oct. 6, 2022 and submitted Oct. 8, 2022, 4:40 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Right now this does the bare minimum to make the user show up on the IRC
network.

Testing Done

Connected to a local ergo instance on 6667 with no TLS and verified that ergo accepted the registration.

Commits

Summary	ID
Add connection registration to the IRCv3 protocol plugin Right now this does the bare minimum to make the user show up on the IRC network.	864d767c930b47d680c384f0dbcf1b2030000627

Issues

Description	From	Last Updated
This doesn't seem to match the IRCv3 format docs: https://modern.ircdocs.horse/#user-message	QuLogic	Oct. 8, 2022, 3:47 a.m.
I'm not sure if it's necessary here, but you may want to check that the error is not G_IO_ERROR_CANCELLED.	QuLogic	Oct. 8, 2022, 4:34 a.m.

libpurple/protocols/ircv3/purpleircv3connection.c (Diff revision 1)
The issue has been resolved. Show all issues
```
This doesn't seem to match the IRCv3 format docs: https://modern.ircdocs.horse/#user-message
```

libpurple/protocols/ircv3/purpleircv3connection.c (Diff revision 1)

The issue has been dropped. Show all issues

I'm not sure if it's necessary here, but you may want to check that the error is not G_IO_ERROR_CANCELLED.

QuLogic Oct. 8, 2022, 3:47 a.m.

What I meant is just ignoring cancelled entirely. If you got that, then the connection is being shut down, in which case a cancel is expected and not an error.

QuLogic Oct. 8, 2022, 3:54 a.m.

Though now I see that purple_connection_g_error (and thus purple_connection_take_error) ignores G_IO_ERROR_CANCELLED, so we don't even need to special case it here like I originally asked.

grim Oct. 8, 2022, 4:24 a.m.

I just noticed that in the connection docs while tweaking, so I'll just remove the conditional here.

Change Summary:

address issues

Commits:

	Summary	ID
	Add connection registration to the IRCv3 protocol plugin Right now this does the bare minimum to make the user show up on the IRC network.	a02c96b3dd68fc8edbbd115a8af6cacfcea7ec3e
	Add connection registration to the IRCv3 protocol plugin Right now this does the bare minimum to make the user show up on the IRC network.	3a198bc98b30bff23dbe6568a985f1d91910db27

Diff:

Revision 2 (+216 -2)

Show changes

	libpurple/protocols/ircv3/purpleircv3connection.h
	libpurple/protocols/ircv3/purpleircv3connection.c

Change Summary:

revert handling the cancellable as purple_connection_take_g_error ignores G_IO_ERROR_CANCELLED

Commits:

	Summary	ID
	Add connection registration to the IRCv3 protocol plugin Right now this does the bare minimum to make the user show up on the IRC network.	3a198bc98b30bff23dbe6568a985f1d91910db27
	Add connection registration to the IRCv3 protocol plugin Right now this does the bare minimum to make the user show up on the IRC network.	864d767c930b47d680c384f0dbcf1b2030000627

Diff:

Revision 3 (+208 -2)

Show changes

	libpurple/protocols/ircv3/purpleircv3connection.h
	libpurple/protocols/ircv3/purpleircv3connection.c

Ship it!

```
Ship It!
```

Status:: Completed