Summary

Work around a timing issues with accounts that have no passwords.

Review Request #1896 — Created Oct. 6, 2022 and submitted Oct. 6, 2022, 3:06 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

There will be a better fix for this, but it's going to be a bit involved. The
problem stems from `purple_account_set_enabled` which is bringing the account
online as soon as that is set. At startup, the accounts are unserialized from
accounts.xml, which sets the enabled property, which causes the account to
connect before the rest of the core is started.

Testing Done

Started pidgin3 with an account that fails to connect 100% of the time and verified nothing crashed.

Commits

Summary	ID
Work around a timing issues with accounts that have no passwords. There will be a better fix for this, but it's going to be a bit involved. The problem stems from `purple_account_set_enabled` which is bringing the account online as soon as that is set. At startup, the accounts are unserialized from accounts.xml, which sets the enabled property, which causes the account to connect before the rest of the core is started.	ed9723cd307dfb0f39260a7537b9553fbab6d636

Summary

Work around a timing issues with accounts that have no passwords.

There will be a better fix for this, but it's going to be a bit involved. The problem stems from `purple_account_set_enabled` which is bringing the account online as soon as that is set. At startup, the accounts are unserialized from accounts.xml, which sets the enabled property, which causes the account to connect before the rest of the core is started.

ed9723cd307dfb0f39260a7537b9553fbab6d636

Ship it!

```
Ship It!
```

Looks like what I proposed as a quick fix, but with correctly-done types.

grim Oct. 6, 2022, 2:58 a.m.

and the very important G_SOURCE_REMOVE that was missing from yours and causing me to flood libera :)

Status:: Completed