Summary

A bunch of cleanup to the UPnP discoverer

Review Request #1893 — Created Oct. 4, 2022 and submitted Oct. 5, 2022, 7:19 a.m.

Information

Owner

grim

Repository

traversity/traversity

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This is still non-functional and not fully implemented. This is on purpose as
the current async setup for all discoverers isn't going to work right and we
need to change that. But rather than do all of that here, I opted to get these
changes reviewed before changing that API.

Testing Done

Compiled

Commits

Summary	ID
A bunch of cleanup to the UPnP discoverer This is still non-functional and not fully implemented. This is on purpose as the current async setup for all discoverers isn't going to work right and we need to change that. But rather than do all of that here, I opted to get these changes reviewed before changing that API.	cff4990fcf3cb2715a58f5f90b4ea1b2bd121423

Issues

Description	From	Last Updated
This is public API but traversity_upnp_discoverer_new_custom is not present in the header file. Shouldn't it be?	ivanhoe	Oct. 5, 2022, 6:40 a.m.

traversity/traversityupnpdiscoverer.c (Diff revision 1)

The issue has been resolved. Show all issues

This is public API but traversity_upnp_discoverer_new_custom is not present in the header file. Shouldn't it be?

Change Summary:

add traversity_upnp_discover_new_custom to the header file

Commits:

	Summary	ID
	A bunch of cleanup to the UPnP discoverer This is still non-functional and not fully implemented. This is on purpose as the current async setup for all discoverers isn't going to work right and we need to change that. But rather than do all of that here, I opted to get these changes reviewed before changing that API.	e399985d84a3e66ceb64c2912db44366d25e9a54
	A bunch of cleanup to the UPnP discoverer This is still non-functional and not fully implemented. This is on purpose as the current async setup for all discoverers isn't going to work right and we need to change that. But rather than do all of that here, I opted to get these changes reviewed before changing that API.	7a7b7c2347a8e41cf4dcd3ed9a4a94bc1944cee2

Diff:

Revision 2 (+496 -60)

Show changes

	traversity/meson.build
	traversity/traversityupnpdiscoverer.h
	traversity/traversityupnpdiscoverer.c

Change Summary:

get all the commits this time...

Commits:

	Summary	ID
	A bunch of cleanup to the UPnP discoverer This is still non-functional and not fully implemented. This is on purpose as the current async setup for all discoverers isn't going to work right and we need to change that. But rather than do all of that here, I opted to get these changes reviewed before changing that API.	7a7b7c2347a8e41cf4dcd3ed9a4a94bc1944cee2
	A bunch of cleanup to the UPnP discoverer This is still non-functional and not fully implemented. This is on purpose as the current async setup for all discoverers isn't going to work right and we need to change that. But rather than do all of that here, I opted to get these changes reviewed before changing that API.	cff4990fcf3cb2715a58f5f90b4ea1b2bd121423

Diff:

Revision 3 (+496 -60)

Show changes

	traversity/meson.build
	traversity/traversityupnpdiscoverer.h
	traversity/traversityupnpdiscoverer.c

Ship it!

```
Ship It!
```

Status:: Completed