Summary

Prompt for a optional password when the user has said it's required

Review Request #1878 — Created Oct. 2, 2022 and submitted Oct. 4, 2022, 3:29 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17691

Depends On

Reviewers

Groups

pidgin

People

Description

Prompt for a optional password when the user has said it's required

Testing Done

Connected an IRC account normally verified it connected.
Closed Pidgin, opened accounts.xml, manually set the require_password property for that account. Reopened Pidgin, connected the account and verified that I got prompted for a password.

Commits

Summary	ID
Prompt for a optional password when the user has said it's required	7e21bedfa4f7d25a0d6a858896bcbc6fd58c8346

Issues

Description	From	Last Updated
Should we check OPT_PROTO_NO_PASSWORD here as well?	QuLogic	Oct. 4, 2022, 3:10 a.m.

libpurple/account.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Should we check OPT_PROTO_NO_PASSWORD here as well?
```
1. grim Oct. 4, 2022, 3:10 a.m.
  Yep!

Change Summary:

Check if the protocol has no passwords and set required_password to false.

Commits:

	Summary	ID
	Prompt for a optional password when the user has said it's required	dc6748350138b7af5a4c738762db4b040d836a15
	Prompt for a optional password when the user has said it's required	7e21bedfa4f7d25a0d6a858896bcbc6fd58c8346

Diff:

Revision 2 (+54 -18)

Show changes

libpurple/account.c

Ship it!

```
Ship It!
```

Status:: Completed

libpurple/account.c (Diff revision 1)