Summary

Add a person property to PurpleContact

Review Request #1852 — Created Sept. 28, 2022 and submitted Sept. 29, 2022, 5:51 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

Add a person property to PurpleContact

Testing Done

Ran the unit tests.

Commits

Summary	ID
Add a person property to PurpleContact	16d822276c121345795b72964f8769b8ea2508b5

Issues

Description	From	Last Updated
Person is leaking here. I think person1 needs to be g_object_unref'd too.	ivanhoe	Sept. 29, 2022, 5:16 a.m.

libpurple/purplecontact.h (Diff revision 1)

Not part of this RR, but in case you need to touch this file again, there's a missing transfer annotation here.

libpurple/tests/test_contact.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Person is leaking here. I think person1 needs to be g_object_unref'd too.
```

Change Summary:

fix leak in memory

Commits:

	Summary	ID
	Add a person property to PurpleContact	b2a5dfe841f81ff6b4169ce57c1e564d5492f7fc
	Add a person property to PurpleContact	16d822276c121345795b72964f8769b8ea2508b5

Diff:

	libpurple/purplecontact.h
	libpurple/purplecontact.c
	libpurple/purpleperson.h
	libpurple/tests/test_contact.c

Ship it!