Summary

Make purple_contact_new take the id instead of the username.

Review Request #1851 — Created Sept. 28, 2022 and submitted Sept. 29, 2022, 8:50 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~1850~~

Groups

People

Description

Username is already readwrite, but id is not, and most protocols have id's for
everything, so lets make that the normal case in the api.

Testing Done

Ran the unit tests.

Commits

Summary	ID
Make purple_contact_new take the id instead of the username. Username is already readwrite, but id is not, and most protocols have id's for everything, so lets make that the normal case in the api.	2c40fc78d9f161bc217b1ae6abb5ce7657e9fdf1

Issues

Description	From	Last Updated
Do you want to add a note on what happens if it's NULL?	QuLogic	Sept. 29, 2022, 8:47 a.m.

Change Summary:

rebased

Commits:

	Summary	ID
	Make purple_contact_new take the id instead of the username. Username is already readwrite, but id is not, and most protocols have id's for everything, so lets make that the normal case in the api.	5757d8a94e73969552fe9ce694a90622b00bb8eb
	Make purple_contact_new take the id instead of the username. Username is already readwrite, but id is not, and most protocols have id's for everything, so lets make that the normal case in the api.	e6fd5e98df21890f6400c3154a1492378187a20b

Diff:

	libpurple/purplecontact.h
	libpurple/purplecontact.c
	libpurple/purplecontactmanager.c
	libpurple/tests/test_contact.c
	libpurple/tests/test_contact_manager.c

libpurple/purplecontact.h (Diff revision 2)
The issue has been resolved. Show all issues
```
Do you want to add a note on what happens if it's NULL?
```

Change Summary:

update does on purple_contact_new

Commits:

	Summary	ID
	Make purple_contact_new take the id instead of the username. Username is already readwrite, but id is not, and most protocols have id's for everything, so lets make that the normal case in the api.	e6fd5e98df21890f6400c3154a1492378187a20b
	Make purple_contact_new take the id instead of the username. Username is already readwrite, but id is not, and most protocols have id's for everything, so lets make that the normal case in the api.	2c40fc78d9f161bc217b1ae6abb5ce7657e9fdf1

Diff:

	libpurple/purplecontact.h
	libpurple/purplecontact.c
	libpurple/purplecontactmanager.c
	libpurple/tests/test_contact.c
	libpurple/tests/test_contact_manager.c

Ship it!

libpurple/purplecontact.h (Diff revision 2)