Summary

Clean up setting handling for the credential manager and make its unit tests don't mess up the others

Review Request #1826 — Created Sept. 23, 2022 and submitted Sept. 23, 2022, 3:28 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

Clean up setting handling for the credential manager and make its unit tests don't mess up the others

Testing Done

removed build/libpurple/tests/config and ran the unit tests. the purple path tests are still failing, but that's unrelated.

Commits

Summary	ID
Clean up setting handling for the credential manager and make its unit tests don't mess up the others	f6d0030524d4b8ec9d2ae12a18b30aed82434c96

Summary:

purple_credential_manager_set_active can take a NULL so reset the preference instead of leaving it

Clean up setting handling for the credential manager and make its unit tests don't mess up the others

Description:

~		purple_credential_manager_set_active can take a NULL so reset the preference instead of leaving it
	~	Clean up setting handling for the credential manager and make its unit tests don't mess up the others

Testing Done:

~		Compiled
	~	removed `build/libpurple/tests/config` and ran the unit tests. the `purple path` tests are still failing, but that's unrelated.

Commits:

	Summary	ID
	purple_credential_manager_set_active can take a NULL so reset the preference instead of leaving it	4971581b2406ce91e8039bf27685489c9cd9637b
	Clean up setting handling for the credential manager and make its unit tests don't mess up the others	f6d0030524d4b8ec9d2ae12a18b30aed82434c96

Diff:

	libpurple/purplecredentialmanager.c
	libpurple/tests/meson.build

Ship it!