Summary

Move the demo to blueprint-compiler

Review Request #1765 — Created Sept. 14, 2022 and submitted Sept. 25, 2022, 6:27 a.m.

Information

Owner

grim

Repository

talkatu/talkatu

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Move the demo to blueprint-compiler

Testing Done


Ran the demo checked just about everything.
Used gresource extract to verify that the XML looked close enough to the old version.

Commits

Summary	ID
Move the demo to blueprint-compiler	13dc9c8e827fdd6fb1569d44253bea1d49512a2f

Issues

Description	From	Last Updated
Should be Talkatu.Buffer	QuLogic	Sept. 25, 2022, 4:46 a.m.
Should be Talkatu.WholeBuffer	QuLogic	Sept. 25, 2022, 4:46 a.m.
Should be Talkatu.MarkdownBuffer	QuLogic	Sept. 25, 2022, 4:46 a.m.
This needs a target or it'll be insensitive.	QuLogic	Sept. 25, 2022, 4:48 a.m.
This makes a parse error for the GdkRGBA. Can it not be an empty string?	QuLogic	Sept. 25, 2022, 5:28 a.m.
This makes a horizontal separator instead of a vertical one. I can't see any difference with Adwaita, but maybe it …	QuLogic	Sept. 25, 2022, 4:47 a.m.
This seems unneeded.	QuLogic	Sept. 25, 2022, 4:47 a.m.
Also unneeded.	QuLogic	Sept. 25, 2022, 4:47 a.m.

Change Summary:

fixed up POTFILES and verified that the blueprint file was being scanned, but it currently throws a warning about unknown extension.

Commits:

	Summary	ID
	Move the demo to blueprint-compiler	3530e570bdf11c28c8f865b020619bf61ed3dc38
	Move the demo to blueprint-compiler	04c042e3618b8aa15bee2c16745e58a376e62834

Diff:

Revision 2 (+578 -704)

Show changes

	meson.build
	demo/meson.build
	demo/talkatudemowindow.c
	demo/data/demo.blp
	demo/data/demo.ui
	demo/data/meson.build
	po/POTFILES
	po/meson.build
	2 more

demo/data/demo.blp (Diff revision 2)
The issue has been resolved. Show all issues
```
Should be Talkatu.Buffer
```
demo/data/demo.blp (Diff revision 2)
The issue has been resolved. Show all issues
```
Should be Talkatu.WholeBuffer
```
demo/data/demo.blp (Diff revision 2)
The issue has been resolved. Show all issues
```
Should be Talkatu.MarkdownBuffer
```
demo/data/demo.blp (Diff revision 2)
The issue has been resolved. Show all issues
```
This needs a target or it'll be insensitive.
```

demo/data/demo.blp (Diff revision 2)

The issue has been resolved. Show all issues

This makes a horizontal separator instead of a vertical one. I can't see any difference with Adwaita, but maybe it makes a difference for other themes.

demo/data/demo.blp (Diff revision 2)
The issue has been resolved. Show all issues
```
This seems unneeded.
```
demo/data/demo.blp (Diff revision 2)
The issue has been resolved. Show all issues
```
Also unneeded.
```

Change Summary:

Address issues

Commits:

	Summary	ID
	Move the demo to blueprint-compiler	04c042e3618b8aa15bee2c16745e58a376e62834
	Move the demo to blueprint-compiler	0b7626f266e6ab6955bc0fd79b1cd317dbbd8685

Diff:

Revision 3 (+584 -706)

Show changes

	meson.build
	demo/meson.build
	demo/talkatudemowindow.c
	demo/data/demo.blp
	demo/data/demo.ui
	demo/data/meson.build
	po/POTFILES
	po/meson.build
	2 more

demo/data/demo.blp (Diff revisions 2 - 3)
The issue has been resolved. Show all issues
```
This makes a parse error for the GdkRGBA. Can it not be an empty string?
```

Change Summary:

Replaced none/"" with black and added a white for dark theme users.

Commits:

	Summary	ID
	Move the demo to blueprint-compiler	0b7626f266e6ab6955bc0fd79b1cd317dbbd8685
	Move the demo to blueprint-compiler	13dc9c8e827fdd6fb1569d44253bea1d49512a2f

Diff:

Revision 4 (+594 -706)

Show changes

	meson.build
	demo/meson.build
	demo/talkatudemowindow.c
	demo/data/demo.blp
	demo/data/demo.ui
	demo/data/meson.build
	po/POTFILES
	po/meson.build
	2 more

Ship it!

```
Ship It!
```

Status:: Completed