Summary

Remove unnecessary NULL check

Review Request #1718 — Created Sept. 5, 2022 and submitted Sept. 6, 2022, 1:37 a.m.

Owner

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

The account is allowed to be NULL here, according to the vfunc documentation,
but the interface method incorrectly enforced non-NULL.

This fixes a critical when selecting Gadu-Gadu in the account editor, as it is the only prpl to implement this method.

Testing Done

Selected Gadu-Gadu in a new account, saw no warnings, and the placeholder text was now added to username.

Commits

Summary	ID
Remove unnecessary NULL check The account is allowed to be `NULL` here, according to the vfunc documentation, but the interface method incorrectly enforced non-`NULL`.	7c1bd7dd1aba97d3ac4f49d2f44033889d655a9e

Change Summary:

Add missing colon.

Commits:

	Summary	ID
	Remove unnecessary NULL check The account is allowed to be `NULL` here, according to the vfunc documentation, but the interface method incorrectly enforced non-`NULL`.	889495375bf7c7a53a076dde74ec4943582a7ede
	Remove unnecessary NULL check The account is allowed to be `NULL` here, according to the vfunc documentation, but the interface method incorrectly enforced non-`NULL`.	7c1bd7dd1aba97d3ac4f49d2f44033889d655a9e

Diff:

	libpurple/purpleprotocolclient.h
	libpurple/purpleprotocolclient.c

Ship it!