Summary

Move proxy preferences to Adwaita preference widgets

Review Request #1678 — Created Aug. 30, 2022 and submitted Aug. 30, 2022, 3:04 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~1677~~

Reviewers

Groups

pidgin

People

Description

Move proxy preferences to Adwaita preference widgets

Testing Done

Forced the options in the source to show each display mode. Clicked Configure Proxy in GNOME mode to open system settings. Changed Proxy type in non-GNOME mode to make other options available (and some network stuff then broke, as expected since I don't really have a proxy.)

Commits

Summary	ID
Move proxy preferences to Adwaita preference widgets	35803c3bc0596977947c9b4b1681f453a14b2a35

Files

Ship it!

```
Ship It!
```
```
Looks good, nice work!!
```

Change Summary:

Add missing activatable-widget annotation.

Commits:

	Summary	ID
	Move proxy preferences to Adwaita preference widgets	f7ab1c72380f216efc037ff1a8797ee1680c981e
	Move proxy preferences to Adwaita preference widgets	35803c3bc0596977947c9b4b1681f453a14b2a35

Diff:

Revision 2 (+182 -286)

Show changes

	pidgin/prefs/pidginproxyprefs.c
	pidgin/resources/Prefs/proxy.ui

Status:: Completed