Fix debug window on GTK4, plus other issues
Review Request #1659 — Created Aug. 26, 2022 and submitted
Fix debug window on GTK4, plus other issues.
- There's no need to go through the request API to make the save button work, so do it with a native file chooser.
- There's an
errorCSS class, so use that instead of our custom one. "working" is the default state, so drop thegood-filterCSS class. - Setting the search entry widget text from the preference seems to cause an infinite loop, and I don't know why the pref would change without the widget doing so, so drop that.
- Move delete stuff into
finalizevfunc. - Moved filter options menu to the 'filter' button, as
GtkSearchEntrydoes not expose the icon as in GTK3.
Opened debug window, set various debug levels, clicked save button and saved log somewhere, entered some text in filter and toggled enable button, right-clicked enable and toggled the Invert and Highlight options.
| Summary | ID |
|---|---|
| 107a30159dec2d59a58e47f02562ba72c6f2f15e |
| Description | From | Last Updated |
|---|---|---|
|
We don't need this if we don't have request windows anymore. |
 grim
|
- Change Summary:
-
Moved filter options menu to the 'filter' button, which allows testing the Invert and Highlight matches button (highlighting is not quite right, but not a GTK4 problem, I think).
Make the save dialog modal, so we don't have to worry about closing it, and useg_file_replaceas the chooser dialog already confirmed the user wanted to overwrite. - Description:
-
Fix debug window on GTK4, plus other issues.
- There's no need to go through the request API to make the save button work, so do it with a native file chooser.
- There's an
errorCSS class, so use that instead of our custom one. "working" is the default state, so drop thegood-filterCSS class.
- Setting the search entry widget text from the preference seems to cause an infinite loop, and I don't know why the pref would change without the widget doing so, so drop that.
- Move delete stuff into
finalizevfunc.
~ ~ - Moved filter options menu to the 'filter' button, as
GtkSearchEntrydoes not expose the icon as in GTK3.
- The filter options menu is currently missing as
GtkSearchEntrydoes not expose the icon as in GTK3. - Testing Done:
-
~ Opened debug window, set various debug levels, clicked save button and saved log somewhere, entered some text in filter and toggled enable button. For some reason, the search term highlighting doesn't work, but the other colours seem to work.
~ Opened debug window, set various debug levels, clicked save button and saved log somewhere, entered some text in filter and toggled enable button, right-clicked enable and toggled the Invert and Highlight options.
- Commits:
-
Summary ID ab4da65731115487f4cd11cf54fe0d8d06f43e8d 107a30159dec2d59a58e47f02562ba72c6f2f15e