Summary

Replace the request_add Account UiOp with a new AddContact notification

Review Request #1624 — Created Aug. 23, 2022 and submitted Aug. 23, 2022, 6:11 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

Add a demo protocol plugin account action to test the new notification

Testing Done

Ran the action from the demo protocol plugin and verified it acted appropriately. However, nothing actually adds the buddy to your list right now.

Was unable to test finch as it's crashing at startup for unrelated issues.

Commits

Summary	ID
Replace the request_add Account UiOp with a new AddContact notification Add a demo protocol plugin account action to test the new notification	ace21fca67b303dba32c90d98873ca3045c24b5a

Issues

Description	From	Last Updated
'mini' sorts below 'make'	QuLogic	Aug. 23, 2022, 6:08 a.m.
Are we removing id later? It's unused.	QuLogic	Aug. 23, 2022, 6:08 a.m.
has added you	QuLogic	Aug. 23, 2022, 6:08 a.m.
No accept or deny here.	QuLogic	Aug. 23, 2022, 6:08 a.m.

ChangeLog.API (Diff revision 1)
The issue has been resolved. Show all issues
```
'mini' sorts below 'make'
```
libpurple/account.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Are we removing id later? It's unused.
```
libpurple/purpleaddcontactrequest.h (Diff revision 1)
The issue has been resolved. Show all issues
```
has added you
```
libpurple/purpleaddcontactrequest.c (Diff revision 1)
The issue has been resolved. Show all issues
```
No accept or deny here.
```

Change Summary:

Address issues.

Commits:

	Summary	ID
	Replace the request_add Account UiOp with a new AddContact notification Add a demo protocol plugin account action to test the new notification	fc8e79ad29fb0ecccad1fcadb7ca4a404ece4d22
	Replace the request_add Account UiOp with a new AddContact notification Add a demo protocol plugin account action to test the new notification	ace21fca67b303dba32c90d98873ca3045c24b5a

Diff:

Revision 2 (+2154 -2726)

Ship it!

libpurple/account.c (Diff revision 1)