Summary

Implement notifications in Finch

Review Request #1602 — Created Aug. 16, 2022 and submitted Aug. 19, 2022, 5:31 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This includes an Notifications item in the action list that opens the
notifcations list. The notifications list shows the title of each notification
and allows the user to open the notification and interact with it.

Testing Done

Created some accounts that couldn't connect to make their connection errors show up as notifications.

Commits

Summary	ID
Implement notifications in Finch This includes an Notifications item in the action list that opens the notifcations list. The notifications list shows the title of each notification and allows the user to open the notification and interact with it.	0339109f3b79cac53f475bd11937f6180e53e76e

Files

Issues

Description	From	Last Updated
Should be above the other buttons?	QuLogic	Aug. 19, 2022, 5:13 a.m.
Do you need to close the notifications window now? Or at least clear the global.	QuLogic	Aug. 19, 2022, 5:13 a.m.
This always creates a new window; should it open the existing one?	QuLogic	Aug. 19, 2022, 5:24 a.m.

finch/finchnotifications.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Should be above the other buttons?
```

finch/finchnotifications.c (Diff revision 1)

The issue has been resolved. Show all issues

Do you need to close the notifications window now? Or at least clear the global.

Change Summary:

address the issues.

Commits:

	Summary	ID
	Implement notifications in Finch This includes an Notifications item in the action list that opens the notifcations list. The notifications list shows the title of each notification and allows the user to open the notification and interact with it.	56a3a2e97a9e49fbed52c351588632c897ed5a1c
	Implement notifications in Finch This includes an Notifications item in the action list that opens the notifcations list. The notifications list shows the title of each notification and allows the user to open the notification and interact with it.	7769a6af540f06ca0f017c31354f994dc2fe3360

Diff:

Revision 2 (+744 -60)

Show changes

	finch/finchnotifications.h
	finch/finchnotifications.c
	finch/gntconn.c
	finch/gntui.c
	finch/meson.build

finch/finchnotifications.c (Diff revision 2)
The issue has been resolved. Show all issues
```
This always creates a new window; should it open the existing one?
```

Change Summary:

Present the window if it's already visible.

Commits:

	Summary	ID
	Implement notifications in Finch This includes an Notifications item in the action list that opens the notifcations list. The notifications list shows the title of each notification and allows the user to open the notification and interact with it.	7769a6af540f06ca0f017c31354f994dc2fe3360
	Implement notifications in Finch This includes an Notifications item in the action list that opens the notifcations list. The notifications list shows the title of each notification and allows the user to open the notification and interact with it.	0339109f3b79cac53f475bd11937f6180e53e76e

Diff:

Revision 3 (+756 -60)

Show changes

	finch/finchnotifications.h
	finch/finchnotifications.c
	finch/gntconn.c
	finch/gntui.c
	finch/meson.build

Ship it!

```
Ship It!
```

Status:: Completed