Summary

Create a new PidginAddChatDialog widget.

Review Request #1590 — Created Aug. 14, 2022 and submitted Aug. 18, 2022, 11:29 p.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This is a full replacement of the existing code in gtkblist.c. Some of the code
remains as it was reused by the join chat dialog code.

Testing Done


Added/Removed a chat on XMPP under valgrind
Opened the roomlist from the dialog with both IRC and XMPP accounts selected.

Commits

Summary	ID
Create a new PidginAddChatDialog widget. This is a full replacement of the existing code in gtkblist.c. Some of the code remains as it was reused by the join chat dialog code.	c37ed200a31d40bdc4f35d586b87a4ced9258b97

Issues

Description	From	Last Updated
Should you call pidgin_add_chat_dialog_update_components after this? Not sure how the name gets pre-filled without it.	QuLogic	Aug. 18, 2022, 11:22 p.m.

Change Summary:

move button to actions

Commits:

	Summary	ID
	Create a new PidginAddChatDialog widget. This is a full replacement of the existing code in gtkblist.c. Some of the code remains as it was reused by the join chat dialog code.	4fcc77d067a286a5ef577405eb4fd9ddad494093
	Create a new PidginAddChatDialog widget. This is a full replacement of the existing code in gtkblist.c. Some of the code remains as it was reused by the join chat dialog code.	c4fc2adc1d8da73877c44a54a1039afdccb7e7e5

Diff:

Revision 2 (+1680 -376)

Show changes

	pidgin/gtkblist.c
	pidgin/meson.build
	pidgin/pidginaddchatdialog.h
	pidgin/pidginaddchatdialog.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/Dialogs/addchat.ui
	po/POTFILES.in

pidgin/pidginaddchatdialog.c (Diff revision 2)

The issue has been resolved. Show all issues

Should you call pidgin_add_chat_dialog_update_components after this?
Not sure how the name gets pre-filled without it.

grim Aug. 18, 2022, 11:12 p.m.
```
nice catch!
```

Change Summary:

call update components to prefil the entries.

Commits:

	Summary	ID
	Create a new PidginAddChatDialog widget. This is a full replacement of the existing code in gtkblist.c. Some of the code remains as it was reused by the join chat dialog code.	c4fc2adc1d8da73877c44a54a1039afdccb7e7e5
	Create a new PidginAddChatDialog widget. This is a full replacement of the existing code in gtkblist.c. Some of the code remains as it was reused by the join chat dialog code.	b81f7d6cfbd891dbe1d9a4cefced5b2d19bf98a7

Diff:

Revision 3 (+1684 -376)

Show changes

	pidgin/gtkblist.c
	pidgin/meson.build
	pidgin/pidginaddchatdialog.h
	pidgin/pidginaddchatdialog.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/Dialogs/addchat.ui
	po/POTFILES.in

Ship it!

```
Ship It!
```

Change Summary:

rebased

Commits:

	Summary	ID
	Create a new PidginAddChatDialog widget. This is a full replacement of the existing code in gtkblist.c. Some of the code remains as it was reused by the join chat dialog code.	b81f7d6cfbd891dbe1d9a4cefced5b2d19bf98a7
	Create a new PidginAddChatDialog widget. This is a full replacement of the existing code in gtkblist.c. Some of the code remains as it was reused by the join chat dialog code.	c37ed200a31d40bdc4f35d586b87a4ced9258b97

Diff:

Revision 4 (+1684 -376)

Show changes

	pidgin/gtkblist.c
	pidgin/meson.build
	pidgin/pidginaddchatdialog.h
	pidgin/pidginaddchatdialog.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/Dialogs/addchat.ui
	po/POTFILES.in

Status:: Completed