A bunch of random fixes for the the gtk4 branch

 






 

 


  Review Request #1581
  —
  Created Aug. 11, 2022 and submitted 

 




















 

  

   Information

  





 
 

  grim
 









 
 

  pidgin/pidgin
 









 
 

  gtk4
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
A bunch of random fixes for the the gtk4 branch

 








  


 
 

  
Compiled

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     
A bunch of random fixes for the the gtk4 branch


    		
    df64d1cb5d15e265e7ab4e5df6a2a1b734df1cf0

   



  
 




 













 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
Those gtk_box_pack_end are confusing; I hope I commented on all the right ones in the end.

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
Is this a GtkWindow? I think it's a widget in the gtkmedia (which is the window).

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
This is definitely not a window.

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
Should be applied to progress_parent, and as it's packed into volume_widget, which is horizontal, these should be hexpand/halign.

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
Should be applied to progress_parent, and as it's packed into volume_widget, which is horizontal, these should be hexpand/halign.

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
So gtkmedia->priv->display is not set to anything... It was removed in /r/1572, but it was a horizontal bbox, so these …

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
Ditto.

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
end -> prepend, not append?

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
recv_widget appears to be vertical, so you only need the v ones.

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
Same for send_widget.

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
end -> prepend, not append?

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
end -> prepend not append?

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
So this only needs to have valign, but also I just noticed, should this be appended to send_widget, not recv_widget?

      		
      
       QuLogicQuLogic
      
      
       
      
     


    
   

  

 







 






  

 








 














 





 

  

   




QuLogic




   

   







  

 



 

  


   

   

    
 
QuLogic


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 







  2. 
 
    
  
  
    
  
   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Those gtk_box_pack_end are confusing; I hope I commented on all the right ones in the end.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      tell me about it...
      
 
      

      2. 


 
    


    

 
    

    3. 















  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       pidgin/gtkmedia.c
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Is this a GtkWindow? I think it's a widget in the gtkmedia (which is the window).
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      yeah after more digging this is NOT the window.
      
 
      

      2. 


 
    


    

 
    

    4. 






  4. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       pidgin/gtkmedia.c
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    This is definitely not a window.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 






  5. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       pidgin/gtkmedia.c
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Should be applied to progress_parent, and as it's packed into volume_widget, which is horizontal, these should be hexpand/halign.
    
  
    
 
    

 
    
  



 
    

    6. 






  6. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       pidgin/gtkmedia.c
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Should be applied to progress_parent, and as it's packed into volume_widget, which is horizontal, these should be hexpand/halign.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    7. 






  7. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       pidgin/gtkmedia.c
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    So gtkmedia->priv->display is not set to anything...
    

    It was removed in /r/1572, but it was a horizontal bbox, so these should be hexpand/halign for that. But I don't know what gtkmedia->priv->display will end up being in the future... So maybe do both?
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    8. 






  8. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       pidgin/gtkmedia.c
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Ditto.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    9. 






  9. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       pidgin/gtkmedia.c
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    end -> prepend, not append?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      

      

      

      gtk_box_pack_end
      
Adds child to box , packed with reference to the end of box . The child is packed after (away from end of) any other child packed with reference to the end of box .
      

      

      Basically end and prepend back on the left, but start and append pack on the right.
      

      I can't read, this should be using prepend..
      
 
      

      2. 


 
    


    

 
    

    10. 






  10. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       pidgin/gtkmedia.c
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

     
     
    

     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    recv_widget appears to be vertical, so you only need the v ones.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    11. 






  11. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       pidgin/gtkmedia.c
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

     
     
    

     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Same for send_widget.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    12. 






  12. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       pidgin/gtkmedia.c
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    end -> prepend, not append?
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    13. 






  13. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       pidgin/gtkmedia.c
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    end -> prepend not append?
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    14. 




  14. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    15. 




  

 
















 



 

  

   




grim




   

   

  

 



 















 





 

  

   




QuLogic




   

   







  

 



 

  


   

   

    
 
QuLogic


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       pidgin/gtkmedia.c
       


        (Diff revision 2)


       
      
     
    
        
    
     
     
    

     
     
    

     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    So this only needs to have valign, but also I just noticed, should this be appended to send_widget, not recv_widget?
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




grim




   

   

  

 



 















 





 

  

   




QuLogic




   

   







  

 



 

  


   

   

    
 
QuLogic


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




grim




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed