Summary

Create PidginAddBuddyDialog.

Review Request #1574 — Created Aug. 8, 2022 and submitted Aug. 12, 2022, 3:15 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This is a GtkBuilder based version of the old hand built code. Nearly all
functionality. The only thing we dropped was the "auto personize" stuff as
that API is private to gtkblist.c.

Testing Done


Added a buddy with and without groups and aliases.
Verified only accounts that allow adding buddies show up in the account list.
Verified that hitting enter on the username entry will submit the ok response.
Couldn't test invite message as no in tree prpls support them.

Commits

Summary	ID
Create PidginAddBuddyDialog. This is a GtkBuilder based version of the old hand built code. Nearly all functionality. The only thing we dropped was the "auto personize" stuff as that API is private to gtkblist.c.	23bc7a89fc870bccc4504f2205393a58c932e9d4

Issues

Description	From	Last Updated
Could this be gtk_combo_box_text_get_active_entry?	QuLogic	Aug. 12, 2022, 2:51 a.m.
its	QuLogic	Aug. 12, 2022, 2:51 a.m.
Can you not set this up in the .ui file? It seems like we do that in proxyoptions.ui.	QuLogic	Aug. 12, 2022, 2:53 a.m.
Is this gtk_combo_box_text_get_active_text? (but that's not const, so not exactly the same)	QuLogic	Aug. 12, 2022, 2:53 a.m.
This is not const any more.	QuLogic	Aug. 12, 2022, 3:04 a.m.

pidgin/pidginaddbuddydialog.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Could this be gtk_combo_box_text_get_active_entry?
```
pidgin/pidginaddbuddydialog.c (Diff revision 1)
The issue has been resolved. Show all issues
```
its
```

pidgin/pidginaddbuddydialog.c (Diff revision 1)

The issue has been resolved. Show all issues

Can you not set this up in the .ui file? It seems like we do that in proxyoptions.ui.

grim Aug. 12, 2022, 1:35 a.m.

I did this this way because I didn't want to create an entirely new filter for accounts that support buddies. So the .ui file use the online file on top of PidginAccountStore but I couldn't put another filter function into that in the .ui file.

QuLogic Aug. 12, 2022, 2:03 a.m.

I don't think proxyoptions.ui does a new filter, just a GtkTreeModelFilter.

pidgin/pidginaddbuddydialog.c (Diff revision 1)

The issue has been resolved. Show all issues

Is this gtk_combo_box_text_get_active_text? (but that's not const, so not exactly the same)

Change Summary:

removed all the properties, moved the filter to glade, yelled at some cats, you now typically thursday late night stream...

Commits:

	Summary	ID
	Create PidginAddBuddyDialog. This is a GtkBuilder based version of the old hand built code. Nearly all functionality. The only thing we dropped was the "auto personize" stuff as that API is private to gtkblist.c.	f002753309b08c20cc78c863e40bcf8a4b09a2a9
	Create PidginAddBuddyDialog. This is a GtkBuilder based version of the old hand built code. Nearly all functionality. The only thing we dropped was the "auto personize" stuff as that API is private to gtkblist.c.	05e1d0ab76ea3e29c2616d82cbf10bb827ed387e

Diff:

Revision 2 (+1504 -420)

Show changes

	pidgin/gtkblist.c
	pidgin/meson.build
	pidgin/pidginaddbuddydialog.h
	pidgin/pidginaddbuddydialog.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/Dialogs/addbuddy.ui
	po/POTFILES.in

pidgin/pidginaddbuddydialog.c (Diff revision 2)
The issue has been resolved. Show all issues
```
This is not const any more.
```

Commits:

	Summary	ID
	Create PidginAddBuddyDialog. This is a GtkBuilder based version of the old hand built code. Nearly all functionality. The only thing we dropped was the "auto personize" stuff as that API is private to gtkblist.c.	05e1d0ab76ea3e29c2616d82cbf10bb827ed387e
	Create PidginAddBuddyDialog. This is a GtkBuilder based version of the old hand built code. Nearly all functionality. The only thing we dropped was the "auto personize" stuff as that API is private to gtkblist.c.	23bc7a89fc870bccc4504f2205393a58c932e9d4

Diff:

Revision 3 (+1508 -420)

Show changes

	pidgin/gtkblist.c
	pidgin/meson.build
	pidgin/pidginaddbuddydialog.h
	pidgin/pidginaddbuddydialog.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/Dialogs/addbuddy.ui
	po/POTFILES.in

Ship it!

```
Ship It!
```

Status:: Completed