Create PidginAddBuddyDialog.

 






 

 


  Review Request #1574
  —
  Created Aug. 9, 2022 and submitted 

 




















 

  

   Information

  





 
 

  grim
 









 
 

  pidgin/pidgin
 









 
 

  default
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
This is a GtkBuilder based version of the old hand built code. Nearly all
functionality. The only thing we dropped was the "auto personize" stuff as
that API is private to gtkblist.c.

 








  


 
 

  
    

  • Added a buddy with and without groups and aliases.
    • 

  • Verified only accounts that allow adding buddies show up in the account list.
    • 

  • Verified that hitting enter on the username entry will submit the ok response.
    • 

  • Couldn't test invite message as no in tree prpls support them.
    • 


 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Create PidginAddBuddyDialog.
      
This is a GtkBuilder based version of the old hand built code. Nearly all
functionality. The only thing we dropped was the "auto personize" stuff as
that API is private to gtkblist.c.

     


    		
    23bc7a89fc870bccc4504f2205393a58c932e9d4

   



  
 




 













 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
Could this be gtk_combo_box_text_get_active_entry?

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
its

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
Can you not set this up in the .ui file? It seems like we do that in proxyoptions.ui.

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
Is this gtk_combo_box_text_get_active_text? (but that's not const, so not exactly the same)

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
This is not const any more.

      		
      
       QuLogicQuLogic
      
      
       
      
     


    
   

  

 







 






  

 








 














 





 

  

   




QuLogic




   

   







  

 



 

  


   

   

    
 
QuLogic


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       pidgin/pidginaddbuddydialog.c
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Could this be gtk_combo_box_text_get_active_entry?
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       pidgin/pidginaddbuddydialog.c
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    its
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 






  4. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       pidgin/pidginaddbuddydialog.c
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Can you not set this up in the .ui file? It seems like we do that in proxyoptions.ui.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I did this this way because I didn't want to create an entirely new filter for accounts that support buddies. So the .ui file use the online file on top of PidginAccountStore but I couldn't put another filter function into that in the .ui file.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      I don't think proxyoptions.ui does a new filter, just a GtkTreeModelFilter.
      
 
      

      3. 


 
    


    

 
    

    5. 






  5. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       pidgin/pidginaddbuddydialog.c
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Is this gtk_combo_box_text_get_active_text? (but that's not const, so not exactly the same)
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    6. 




  6. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    7. 




  

 
















 



 

  

   




grim




   

   

  

 



 















 





 

  

   




QuLogic




   

   







  

 



 

  


   

   

    
 
QuLogic


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       pidgin/pidginaddbuddydialog.c
       


        (Diff revision 2)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    This is not const any more.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




grim




   

   

  

 



 















 





 

  

   




QuLogic




   

   







  

 



 

  


   

   

    
 
QuLogic


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




grim




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed