Summary

Convert PidginAccountsEnabledMenu from a menu controller to a GMenuModel

Review Request #1527 — Created July 19, 2022 and submitted July 29, 2022, 2:32 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

Convert PidginAccountsEnabledMenu from a menu controller to a GMenuModel

Testing Done

Enabled and disabled a bunch of accounts from the menus while running under valgrind.

Commits

Summary	ID
Convert PidginAccountsEnabledMenu from a menu controller to a GMenuModel	ab60ab6ae161d84bb45aed9c8106272510c3b111

Issues

Description	From	Last Updated
value is leaked.	QuLogic	July 29, 2022, 2:16 a.m.

Change Summary:

rebased

Commits:

	Summary	ID
	Convert PidginAccountsEnabledMenu from a menu controller to a GMenuModel	c76112bf7ead03ec12a1a4bfa7e12d1f3a5fbaab
	Convert PidginAccountsEnabledMenu from a menu controller to a GMenuModel	ff307a5316466c3805ecf8c984794e75bafe65c7

Diff:

Revision 2 (+584 -178)

	libpurple/purplemenu.h
	libpurple/purplemenu.c
	pidgin/pidginaccountsenabledmenu.h
	pidgin/pidginaccountsenabledmenu.c
	pidgin/pidginapplication.c

Ship it!

libpurple/purplemenu.c (Diff revision 2)
The issue has been resolved. Show all issues
```
value is leaked.
```

Change Summary:

don't leak value

Commits:

	Summary	ID
	Convert PidginAccountsEnabledMenu from a menu controller to a GMenuModel	ff307a5316466c3805ecf8c984794e75bafe65c7
	Convert PidginAccountsEnabledMenu from a menu controller to a GMenuModel	ab60ab6ae161d84bb45aed9c8106272510c3b111

Diff:

Revision 3 (+590 -178)

	libpurple/purplemenu.h
	libpurple/purplemenu.c
	pidgin/pidginaccountsenabledmenu.h
	pidgin/pidginaccountsenabledmenu.c
	pidgin/pidginapplication.c

Ship it!

libpurple/purplemenu.c (Diff revision 2)