Summary

Use a HdyStatusPage as a place holder for conversations

Review Request #1519 — Created July 5, 2022 and submitted July 5, 2022, 2:01 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Use a HdyStatusPage as a place holder for conversations

Testing Done

Ran locally.

Commits

Summary	ID
Use a HdyStatusPage as a place holder for conversations	2ee20a6713151f6af95fbe255334ae0d95a62a18

Files

Issues

Description	From	Last Updated
Bit confused about whether this title is used for anything? This one isn't capitalized, and neither is the conversations one, …	QuLogic	July 5, 2022, 1:58 a.m.

pidgin/resources/Conversations/window.ui (Diff revision 1)

The issue has been resolved. Show all issues

Bit confused about whether this title is used for anything?

This one isn't capitalized, and neither is the conversations one, but it also has double underscores.

grim July 5, 2022, 12:22 a.m.

previously i was using the title to switch the stack but now we're usign the name column. The title would only be used but a GtkStackSwitcher or something similar so it's really just there in case. But I have no concerns about deleting it.

QuLogic July 5, 2022, 12:24 a.m.

I guess it's fine to keep, but only if the notifications/conversations titles are consistent. On the other hand, no point in translating it if it's not going to show anywhere.

grim July 5, 2022, 1:47 a.m.
```
Good point on the translation...
```

Change Summary:

remove the title from the placeholders and rebase

Commits:

	Summary	ID
	Use a HdyStatusPage as a place holder for conversations	f2c4a5f450fa8a63e84380609d688c134ed97499
	Use a HdyStatusPage as a place holder for conversations	2ee20a6713151f6af95fbe255334ae0d95a62a18

Diff:

Revision 2 (+36 -26)

Show changes

	pidgin/pidginconversationwindow.c
	pidgin/resources/Conversations/window.ui

Ship it!

```
Ship It!
```

Status:: Completed