Summary

Split away/idle prefs into a separate widget

Review Request #1435 — Created May 13, 2022 and submitted May 13, 2022, 8:17 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~1436~~

Blocks

1441

Reviewers

Groups

pidgin

People

Description

I didn't do any re-designing, but did change GtkFrame to HdyPreferencesGroup, as that allowed using a HdyPreferencesPage like with the credentials page.

Testing Done

Opened Preferences and didn't see any errors. Also, changed all settings and saw that debug log showed they were changed and prefs were re-saving.

Commits

Summary	ID
Split away/idle prefs into a separate widget	00fbef19d730b92a6624ea8aa738c16be67896e2

Issues

Description	From	Last Updated
POTFILES.in should at least include away.ui and probably the .c file.	grim	May 13, 2022, 8:16 a.m.
I've been skipping this specific doc comment in new widgets.	grim	May 13, 2022, 8:16 a.m.

The issue has been resolved. Show all issues

POTFILES.in should at least include away.ui and probably the .c file.

pidgin/prefs/pidginawaypage.h (Diff revision 1)
The issue has been resolved. Show all issues
```
I've been skipping this specific doc comment in new widgets.
```

Change Summary:

Handle comments

Commits:

	Summary	ID
	Split away/idle prefs into a separate widget	0fc3a0be2c59555162f3d9b75fcb71f6e4c0a0ee
	Split away/idle prefs into a separate widget	00fbef19d730b92a6624ea8aa738c16be67896e2

Diff:

Revision 2 (+1186 -950)

Show changes

	pidgin/meson.build
	pidgin/prefs/pidginawaypage.h
	pidgin/prefs/pidginawaypage.c
	pidgin/prefs/pidginprefs.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/Prefs/away.ui
	pidgin/resources/Prefs/prefs.ui
	po/POTFILES.in

Ship it!

```
Ship It!
```
```
Awesome work, thanks!!
```

Status:: Completed