Summary

Port PidginStatusEditor to GTK4

Review Request #1420 — Created May 6, 2022 and submitted May 10, 2022, 8:48 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

gtk4

Bugs

Depends On

Groups

People

Description

Port PidginStatusEditor to GTK4

Testing Done

Compiled.

Commits

Summary	ID
Port PidginStatusEditor to GTK4	dab53257e3f4f3c9410bdc475018817f7e3437e9

Issues

Description	From	Last Updated
This fill isn't applied in the new one.	QuLogic	May 10, 2022, 6:33 a.m.
Ditto.	QuLogic	May 10, 2022, 6:33 a.m.
Ditto.	QuLogic	May 10, 2022, 6:33 a.m.
Ditto.	QuLogic	May 10, 2022, 6:33 a.m.
Ditto.	QuLogic	May 10, 2022, 6:33 a.m.
Ditto.	QuLogic	May 10, 2022, 7:13 a.m.
This is no longer a thing.	QuLogic	May 10, 2022, 7:07 a.m.
And maybe this too can go?	QuLogic	May 10, 2022, 7:07 a.m.
This also needs to go.	QuLogic	May 10, 2022, 8:30 a.m.
These buttons need type="action"	QuLogic	May 10, 2022, 8:30 a.m.

pidgin/resources/Status/editor.ui (Diff revision 1)
The issue has been resolved. Show all issues
```
This fill isn't applied in the new one.
```
pidgin/resources/Status/editor.ui (Diff revision 1)
The issue has been resolved. Show all issues
```
Ditto.
```
pidgin/resources/Status/editor.ui (Diff revision 1)
The issue has been resolved. Show all issues
```
Ditto.
```
pidgin/resources/Status/editor.ui (Diff revision 1)
The issue has been resolved. Show all issues
```
Ditto.
```
pidgin/resources/Status/editor.ui (Diff revision 1)
The issue has been resolved. Show all issues
```
Ditto.
```
pidgin/resources/Status/editor.ui (Diff revision 1)
The issue has been resolved. Show all issues
```
Ditto.
```
pidgin/resources/Status/editor.ui (Diff revision 1)
The issue has been resolved. Show all issues
```
This is no longer a thing.
```
pidgin/resources/Status/editor.ui (Diff revision 1)
The issue has been resolved. Show all issues
```
And maybe this too can go?
```

Change Summary:

address issues.

Commits:

	Summary	ID
	Port PidginStatusEditor to GTK4	c4b12e9edd54d427762898f0494642d35badf376
	Port PidginStatusEditor to GTK4	2f6d18785aa1e359225468498e2166776d119ff7

Diff:

Revision 2 (+134 -348)

	pidgin/pidginstatuseditor.c
	pidgin/resources/Status/editor.ui

pidgin/resources/Status/editor.ui (Diff revision 2)
The issue has been resolved. Show all issues
```
This also needs to go.
```
pidgin/resources/Status/editor.ui (Diff revision 2)
The issue has been resolved. Show all issues
```
These buttons need type="action"
```

Change Summary:

mark the buttons as actions and remove the dialog hint

Commits:

	Summary	ID
	Port PidginStatusEditor to GTK4	2f6d18785aa1e359225468498e2166776d119ff7
	Port PidginStatusEditor to GTK4	dab53257e3f4f3c9410bdc475018817f7e3437e9

Diff:

Revision 3 (+134 -350)

	pidgin/pidginstatuseditor.c
	pidgin/resources/Status/editor.ui

Ship it!