Summary

Add a new templated PidginStatusEditor and wire it up.

Review Request #1363 — Created March 22, 2022 and submitted May 6, 2022, 5:38 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

The substatuses were ignored for now as their future remains unclear. This
greatly simplified this widget.

Testing Done

Tested everything I could think of in the UI as well as ran the docs without issue.

Commits

Summary	ID
Add a new templated PidginStatusEditor and wire it up. The substatuses were ignored for now as their future remains unclear. This greatly simplified this widget.	d93c8c6dbfb7b4c798e9df1091c1c622ca4c25ee

Issues

Description	From	Last Updated
random 1?	lifesfaded	March 22, 2022, 9:08 a.m.
Missing license.	lifesfaded	March 22, 2022, 9:08 a.m.
Transfer annotation?	QuLogic	May 6, 2022, 5:13 a.m.
Is this not a GObject?	QuLogic	May 6, 2022, 5:13 a.m.
Space after comma.	QuLogic	May 6, 2022, 5:13 a.m.
s/-/_/	QuLogic	May 6, 2022, 5:13 a.m.

pidgin/pidginstatuseditor.c (Diff revision 1)
The issue has been resolved. Show all issues
```
random 1?
```
pidgin/resources/Status/editor.ui (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing license.
```

Change Summary:

add license to the ui file and remove random characters

Commits:

	Summary	ID
	Add a new templated PidginStatusEditor and wire it up. The substatuses were ignored for now as their future remains unclear. This greatly simplified this widget.	557734dbc1030f1ffd83872a2c93136eec7f9a26
	Add a new templated PidginStatusEditor and wire it up. The substatuses were ignored for now as their future remains unclear. This greatly simplified this widget.	ab04b8b3b7ea92ede1bcd9f1f4fc461eb380e2e0

Diff:

Revision 2 (+1634 -32)

Show changes

	pidgin/meson.build
	pidgin/pidginstatuseditor.h
	pidgin/pidginstatuseditor.c
	pidgin/pidginstatusmanager.c
	pidgin/pidginstatusprimitivechooser.h
	pidgin/pidginstatusprimitivechooser.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/Status/editor.ui
	2 more

Change Summary:

rebased

Commits:

	Summary	ID
	Add a new templated PidginStatusEditor and wire it up. The substatuses were ignored for now as their future remains unclear. This greatly simplified this widget.	ab04b8b3b7ea92ede1bcd9f1f4fc461eb380e2e0
	Add a new templated PidginStatusEditor and wire it up. The substatuses were ignored for now as their future remains unclear. This greatly simplified this widget.	6be8abc16ee54d7d2f73119493013886bc97e6c7

Diff:

Revision 3 (+1634 -32)

Show changes

	pidgin/meson.build
	pidgin/pidginstatuseditor.h
	pidgin/pidginstatuseditor.c
	pidgin/pidginstatusmanager.c
	pidgin/pidginstatusprimitivechooser.h
	pidgin/pidginstatusprimitivechooser.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/Status/editor.ui
	2 more

pidgin/pidginstatuseditor.h (Diff revision 3)
The issue has been resolved. Show all issues
```
Transfer annotation?
```
pidgin/pidginstatuseditor.c (Diff revision 3)
The issue has been resolved. Show all issues
```
Is this not a GObject?
```
pidgin/pidginstatusmanager.c (Diff revision 3)
The issue has been resolved. Show all issues
```
Space after comma.
```
pidgin/pidginstatusprimitivechooser.h (Diff revision 3)
The issue has been resolved. Show all issues
```
s/-/_/
```

Change Summary:

rebased and addressed issues

Commits:

	Summary	ID
	Add a new templated PidginStatusEditor and wire it up. The substatuses were ignored for now as their future remains unclear. This greatly simplified this widget.	6be8abc16ee54d7d2f73119493013886bc97e6c7
	Add a new templated PidginStatusEditor and wire it up. The substatuses were ignored for now as their future remains unclear. This greatly simplified this widget.	d93c8c6dbfb7b4c798e9df1091c1c622ca4c25ee

Diff:

Revision 4 (+1640 -32)

Show changes

	pidgin/meson.build
	pidgin/pidginstatuseditor.h
	pidgin/pidginstatuseditor.c
	pidgin/pidginstatusmanager.c
	pidgin/pidginstatusprimitivechooser.h
	pidgin/pidginstatusprimitivechooser.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/Status/editor.ui
	2 more

Ship it!

```
Ship It!
```

Status:: Completed

pidgin/pidginstatuseditor.c (Diff revision 1)

pidgin/pidginstatuseditor.h (Diff revision 3)

pidgin/pidginstatuseditor.c (Diff revision 3)