Summary

Create a new status manager that's built in glade

Review Request #1322 — Created March 10, 2022 and submitted March 21, 2022, 8:28 p.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17590

Depends On

Reviewers

Groups

pidgin

People

Description

Behavorial Changes:

* Confirmation dialog for remove has been removed.
* Remove button is disabled if the currently selected status is the active
  status. Previously this scenario was silently ignored after confirmation.

Errata:

It is possible to open multiple modify windows for a status. Previously the
editor was reaching into the manager and controlling this pointer. I was going
to fix this, but the editor isn't a widget yet and I don't like doing duplicate
work.

Testing Done

Basically tried everything I could think of with editing and selecting and so on.

Commits

Summary	ID
Create a new status manager that's built in glade Behavorial Changes: * Confirmation dialog for remove has been removed. * Remove button is disabled if the currently selected status is the active status. Previously this scenario was silently ignored after confirmation. Errata: It is possible to open multiple modify windows for a status. Previously the editor was reaching into the manager and controlling this pointer. I was going to fix this, but the editor isn't a widget yet and I don't like doing duplicate work.	b108bd2f846428e47c4896ce95f80b36f7284e91

Summary

Create a new status manager that's built in glade

Behavorial Changes: * Confirmation dialog for remove has been removed. * Remove button is disabled if the currently selected status is the active status. Previously this scenario was silently ignored after confirmation. Errata: It is possible to open multiple modify windows for a status. Previously the editor was reaching into the manager and controlling this pointer. I was going to fix this, but the editor isn't a widget yet and I don't like doing duplicate work.

b108bd2f846428e47c4896ce95f80b36f7284e91

Files

Issues

Description	From	Last Updated
Should this be _get_default or similar if it never returns a second new one?	QuLogic	March 21, 2022, 8:06 p.m.
Kind of like the below function, this could be changed to: sensitive = status != purple_savedstatus_get_current(); and one set_sensitive call …	QuLogic	March 21, 2022, 8:06 p.m.

Change Summary:

make sure we disconnect our purple signals.

Commits:

	Summary	ID
	Create a new status manager that's built in glade Behavorial Changes: * Confirmation dialog for remove has been removed. * Remove button is disabled if the currently selected status is the active status. Previously this scenario was silently ignored after confirmation. Errata: It is possible to open multiple modify windows for a status. Previously the editor was reaching into the manager and controlling this pointer. I was going to fix this, but the editor isn't a widget yet and I don't like doing duplicate work.	a06334af6463cb09b497e92a21c0a0520d7fc6b7
	Create a new status manager that's built in glade Behavorial Changes: * Confirmation dialog for remove has been removed. * Remove button is disabled if the currently selected status is the active status. Previously this scenario was silently ignored after confirmation. Errata: It is possible to open multiple modify windows for a status. Previously the editor was reaching into the manager and controlling this pointer. I was going to fix this, but the editor isn't a widget yet and I don't like doing duplicate work.	5aad54985d26d1527650aa1d7cd24aa4f4ab248c

Diff:

Revision 2 (+1222 -4)

Show changes

	pidgin/meson.build
	pidgin/pidginapplication.c
	pidgin/pidginstatusmanager.h
	pidgin/pidginstatusmanager.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/Status/manager.ui
	po/POTFILES.in

Change Summary:: add a ticket
Bugs:: PIDGIN-17590

pidgin/pidginstatusmanager.h (Diff revision 2)

The issue has been resolved. Show all issues

Should this be _get_default or similar if it never returns a second new one?

grim March 20, 2022, 4:01 a.m.

Well the only way you'd create another is to manually can g_object_new. fwiw, we already do this with purple_about_dialog_new. https://keep.imfreedom.org/pidgin/pidgin/file/default/pidgin/pidginabout.c#l581
The main reason for this is so that the action callback doesn't need to keep track of it. That said, if we used a static variable in the action with the weak ref would make having the action manage it pretty easy. Thoughts?

pidgin/pidginstatusmanager.c (Diff revision 2)

The issue has been resolved. Show all issues

Kind of like the below function, this could be changed to:
sensitive = status != purple_savedstatus_get_current();

and one set_sensitive call after the if.

Change Summary:

address review issues

Commits:

	Summary	ID
	Create a new status manager that's built in glade Behavorial Changes: * Confirmation dialog for remove has been removed. * Remove button is disabled if the currently selected status is the active status. Previously this scenario was silently ignored after confirmation. Errata: It is possible to open multiple modify windows for a status. Previously the editor was reaching into the manager and controlling this pointer. I was going to fix this, but the editor isn't a widget yet and I don't like doing duplicate work.	5aad54985d26d1527650aa1d7cd24aa4f4ab248c
	Create a new status manager that's built in glade Behavorial Changes: * Confirmation dialog for remove has been removed. * Remove button is disabled if the currently selected status is the active status. Previously this scenario was silently ignored after confirmation. Errata: It is possible to open multiple modify windows for a status. Previously the editor was reaching into the manager and controlling this pointer. I was going to fix this, but the editor isn't a widget yet and I don't like doing duplicate work.	35908aaaf3987656e96be81ae98bf0634dd9c681

Diff:

Revision 3 (+1206 -4)

Show changes

	pidgin/meson.build
	pidgin/pidginapplication.c
	pidgin/pidginstatusmanager.h
	pidgin/pidginstatusmanager.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/Status/manager.ui
	po/POTFILES.in

Change Summary:

forgot to update the docs.

Commits:

	Summary	ID
	Create a new status manager that's built in glade Behavorial Changes: * Confirmation dialog for remove has been removed. * Remove button is disabled if the currently selected status is the active status. Previously this scenario was silently ignored after confirmation. Errata: It is possible to open multiple modify windows for a status. Previously the editor was reaching into the manager and controlling this pointer. I was going to fix this, but the editor isn't a widget yet and I don't like doing duplicate work.	35908aaaf3987656e96be81ae98bf0634dd9c681
	Create a new status manager that's built in glade Behavorial Changes: * Confirmation dialog for remove has been removed. * Remove button is disabled if the currently selected status is the active status. Previously this scenario was silently ignored after confirmation. Errata: It is possible to open multiple modify windows for a status. Previously the editor was reaching into the manager and controlling this pointer. I was going to fix this, but the editor isn't a widget yet and I don't like doing duplicate work.	b108bd2f846428e47c4896ce95f80b36f7284e91

Diff:

Revision 4 (+1206 -4)

Show changes

	pidgin/meson.build
	pidgin/pidginapplication.c
	pidgin/pidginstatusmanager.h
	pidgin/pidginstatusmanager.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/Status/manager.ui
	po/POTFILES.in

Ship it!

```
Ship It!
```

Status:: Completed