Summary

Convert TalkatuDemo to a GtkApplication

Review Request #1260 — Created Jan. 30, 2022 and submitted Jan. 31, 2022, 1:35 a.m.

Information

Owner

QuLogic

Repository

talkatu/talkatu

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

While this is a requirement for GTK4, it can be done in GTK3, so this targets default. I don't know if we want to merge/rebase gtk4 over it, graft it on, or just only apply it to gtk4 and leave default untouched.

Testing Done

Compiled and ran.

Commits

Summary	ID
Convert TalkatuDemo to a GtkApplication	99ab551b97ffe705339e5bb9e72551ae71253560

Issues

Description	From	Last Updated
Why was the short option removed?	grim	Jan. 31, 2022, 1:32 a.m.
trailing whitespace on these two lines	grim	Jan. 30, 2022, 9:57 p.m.
trailing whitespace	grim	Jan. 30, 2022, 9:57 p.m.

We'll probably rebase. I've been purposely not publishing the gtk4 branch assuming we may need to rebase at some point.

demo/talkatudemo.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Why was the short option removed?
```
1. QuLogic Jan. 30, 2022, 9:30 p.m.
  It was added?
2. grim Jan. 30, 2022, 10:58 p.m.
  Yeah that's the 'V'.
3. QuLogic Jan. 30, 2022, 11:35 p.m.
  Yes, it's not removed; it's added.
4. grim Jan. 31, 2022, 1:32 a.m.
  bleh, sorry, nice :)
demo/talkatudemo.c (Diff revision 1)
The issue has been resolved. Show all issues
```
trailing whitespace on these two lines
```
demo/talkatudemo.c (Diff revision 1)
The issue has been resolved. Show all issues
```
trailing whitespace
```

Change Summary:

Drop trailing whitespace

Commits:

	Summary	ID
	Convert TalkatuDemo to a GtkApplication	951199175e79598e51a150a48d22e70eac423f0f
	Convert TalkatuDemo to a GtkApplication	99ab551b97ffe705339e5bb9e72551ae71253560

Diff:

Revision 2 (+112 -132)

Show changes

	demo/talkatudemo.c
	demo/talkatudemowindow.h
	demo/talkatudemowindow.c
	demo/data/demo.ui

Ship it!

```
Ship It!
```
```
Awesome work, thanks!!
```

Status:: Completed

demo/talkatudemo.c (Diff revision 1)

demo/talkatudemo.c (Diff revision 1)

demo/talkatudemo.c (Diff revision 1)