Summary

Port JabberMessage->sent to GDateTime and use g_date_time_new_from_iso8601 instead of purple_str_to_time.

Review Request #1214 — Created Jan. 4, 2022 and submitted Jan. 9, 2022, 2:55 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

Port JabberMessage->sent to GDateTime and use g_date_time_new_from_iso8601 instead of purple_str_to_time.

Testing Done

Send some messages on XMPP including carbons, verified timestamps looked right.

Commits

Summary	ID
Port JabberMessage->sent to GDateTime and use g_date_time_new_from_iso8601 instead of purple_str_to_time.	fe377f5190e6c56d762ed3f171b3c8c5966d6f41

Issues

Description	From	Last Updated
What should the time stamp be if this parsing fails? Probably should only replace timestamp if the result is not …	QuLogic	Jan. 9, 2022, 12:27 a.m.

Ship it!

libpurple/protocols/jabber/message.c (Diff revision 1)

The issue has been resolved. Show all issues

What should the time stamp be if this parsing fails? Probably should only replace timestamp if the result is not NULL only.

Change Summary:

properly handle failed iso8601 parses

Commits:

	Summary	ID
	Port JabberMessage->sent to GDateTime and use g_date_time_new_from_iso8601 instead of purple_str_to_time.	bd14d2117b0688f1385534d5c91519edc9abc2c3
	Port JabberMessage->sent to GDateTime and use g_date_time_new_from_iso8601 instead of purple_str_to_time.	fe377f5190e6c56d762ed3f171b3c8c5966d6f41

Diff:

Revision 2 (+102 -32)

	libpurple/protocols/jabber/message.h
	libpurple/protocols/jabber/message.c

Ship it!