Summary

Add an option to build against libsoup3

Review Request #1210 — Created Dec. 31, 2021 and submitted Jan. 1, 2022, 11:42 p.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17570

Depends On

Reviewers

Groups

pidgin

People

Description

Add an option to build against libsoup3

Testing Done

Ran meson with the option disabled (default) and made sure it made it through configuration.
Ran meson with the option enabled and verified it failed to find libsoup3 on a machine that doesn't have it installed.

Commits

Summary	ID
Add an option to build against libsoup3	7762bf1fd028fad75880fe4da6d66bee62b3b69f

Issues

Description	From	Last Updated
Can drop the required now.	QuLogic	Dec. 31, 2021, 9:44 a.m.
And this check isn't needed since required:true will error if not found.	QuLogic	Jan. 1, 2022, 7:36 a.m.

meson.build (Diff revision 1)
The issue has been resolved. Show all issues
```
Can drop the required now.
```

meson.build (Diff revision 1)

The issue has been resolved. Show all issues

And this check isn't needed since required:true will error if not found.

grim Jan. 1, 2022, 6:51 a.m.
```
Did I not address this?
```

QuLogic Jan. 1, 2022, 7:12 a.m.

Nope, you merged the other top-level ones together, which I didn't notice, actually. This is about the interior if.

grim Jan. 1, 2022, 7:18 a.m.
```
oh, derp yeah
```

Change Summary:

address issues

Commits:

	Summary	ID
	Add an option to build against libsoup3	fb9f890e6a16c65ede7417976e94b5827210b3de
	Add an option to build against libsoup3	b6c9d6b40c97298702ad75b234202bc9ae7c6f1b

Diff:

Revision 2 (+24 -12)

Show changes

	meson.build
	meson_options.txt

Commits:

	Summary	ID
	Add an option to build against libsoup3	b6c9d6b40c97298702ad75b234202bc9ae7c6f1b
	Add an option to build against libsoup3	7762bf1fd028fad75880fe4da6d66bee62b3b69f

Diff:

Revision 3 (+12 -4)

Show changes

	meson.build
	meson_options.txt

Ship it!

```
Ship It!
```

Bugs:: PIDGIN-17570

Status:: Completed