Summary

Remove unnecessary gtk-doc comments and move them where possible from libpurple/[d-m]*.h

Review Request #1179 — Created Dec. 11, 2021 and submitted Dec. 12, 2021, 6:09 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Remove unnecessary gtk-doc comments and move them where possible from libpurple/[d-m]*.h

Testing Done

Compiled

Commits

Summary	ID
Remove unnecessary gtk-doc comments and move them where possible from libpurple/[d-m]*.h	9d49d8b36482efd2142c6eb64e97c2649360c1ff

Issues

Description	From	Last Updated
Maybe we should keep this warning?	QuLogic	Dec. 12, 2021, 5:59 a.m.
Its purpose	QuLogic	Dec. 12, 2021, 4:15 a.m.
This link will need fixing, too, dunno if you're doing those now.	QuLogic	Dec. 12, 2021, 4:15 a.m.

libpurple/glibcompat.h (Diff revision 1)

The issue has been resolved. Show all issues

Maybe we should keep this warning?

grim Dec. 11, 2021, 9:26 p.m.

Maybe? The thing is that we're just doing inline versions of the functions now so it shouldn't matter if it's used in public api..

QuLogic Dec. 12, 2021, 4:15 a.m.

The warning is more about types, I think.

grim Dec. 12, 2021, 5:02 a.m.
```
Oh yeah that could be important...
```

libpurple/memorypool.h (Diff revision 1)
The issue has been resolved. Show all issues
```
Its purpose
```
1. grim Dec. 11, 2021, 9:26 p.m.
  For once this wasn't my doing (I don't think so, but I didn't annotate)!!

libpurple/memorypool.h (Diff revision 1)

The issue has been dropped. Show all issues

This link will need fixing, too, dunno if you're doing those now.

grim Dec. 11, 2021, 9:26 p.m.

Wasn't planning on doing the links now this already grew out of control which is why I broke it up.

Commits:

	Summary	ID
	Remove unnecessary gtk-doc comments and move them where possible from libpurple/[d-m]*.h	b2b8c04c77f3fb98bcfbbebceb10190a9c7c9d5a
	Remove unnecessary gtk-doc comments and move them where possible from libpurple/[d-m]*.h	a41e72d8684e5da9985b55e02d2a883bbcb1677a

Diff:

Revision 2 (+52 -200)

Show changes

	libpurple/debug.h
	libpurple/eventloop.h
	libpurple/glibcompat.h
	libpurple/group.h
	libpurple/idle.h
	libpurple/image.h
	libpurple/image-store.h
	libpurple/internal.h
	4 more

Change Summary:

Rebase and add the warning back to glibcompat.h

Commits:

	Summary	ID
	Remove unnecessary gtk-doc comments and move them where possible from libpurple/[d-m]*.h	a41e72d8684e5da9985b55e02d2a883bbcb1677a
	Remove unnecessary gtk-doc comments and move them where possible from libpurple/[d-m]*.h	9d49d8b36482efd2142c6eb64e97c2649360c1ff

Diff:

Revision 3 (+64 -200)

Show changes

	libpurple/debug.h
	libpurple/eventloop.h
	libpurple/glibcompat.h
	libpurple/group.h
	libpurple/idle.h
	libpurple/image.h
	libpurple/image-store.h
	libpurple/internal.h
	4 more

Ship it!

```
Ship It!
```

Status:: Completed