Summary

Move conversation window key handling into its file

Review Request #1152 — Created Dec. 7, 2021 and submitted Dec. 7, 2021, 2:31 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

There are a bunch of window+conversation key handling bits stuck together when it
really should be something handled on the window only. Using the capture phase
for events allows us to catch the event first before any contained widgets.

Testing Done

Opened multiple conversations and switch between them with Ctrl+[] and Alt+123.

Commits

Summary	ID
Move conversation window key handling into its file There are a bunch of window+conversation key handling stuck together when it really should be something handled on the window only. Using the capture phase for events allows us to catch the event first before any contained widgets.	42d29604fe3968b450206e1e74b598c855b05cb2

Issues

Description	From	Last Updated
can probably drop the common from the name.	grim	Dec. 7, 2021, 2:30 a.m.

pidgin/pidginconversationwindow.c (Diff revision 1)
The issue has been resolved. Show all issues
```
can probably drop the common from the name.
```

Change Summary:

Simplify callback name.

Commits:

	Summary	ID
	Move conversation window key handling into its file There are a bunch of window+conversation key handling stuck together when it really should be something handled on the window only. Using the capture phase for events allows us to catch the event first before any contained widgets.	3157df3b525b6a01d58910ca5b56b80f97561abd
	Move conversation window key handling into its file There are a bunch of window+conversation key handling stuck together when it really should be something handled on the window only. Using the capture phase for events allows us to catch the event first before any contained widgets.	42d29604fe3968b450206e1e74b598c855b05cb2

Diff:

Revision 2 (+100 -54)

Show changes

	pidgin/gtkconv.c
	pidgin/pidginconversationwindow.c

Ship it!

```
Ship It!
```
```
Awesome work, thanks!!
```

Status:: Completed