Summary

Clear conversation typing source ID in callback

Review Request #1123 — Created Nov. 3, 2021 and submitted Nov. 5, 2021, 4:23 a.m.

Information

Owner

sadiq

Repository

pidgin/pidgin

Branch

release-2.x.y

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Since the callback is run only once, the source ID should be
set to 0 so that the source ID won t be an invalid value.

This avoids a GLib critical on removing the invalid Source ID

Testing Done

Build and run pidgin and verified that the GLib warning has gone in logs

Commits

Summary	ID
Clear conversation typing source ID in callback Since the callback is run only once, the source ID should be set to 0 so that the source ID won t be an invalid value. This avoids a GLib critical on removing the invalid Source ID	49ce3f5e1b18ee7065fe622f8936a6c1185490a8

Issues

Description	From	Last Updated
This call is no longer needed.	QuLogic	Nov. 4, 2021, 10:35 p.m.

libpurple/conversation.c (Diff revision 1)
The issue has been resolved. Show all issues
```
This call is no longer needed.
```

Commits:

	Summary	ID
	Clear conversation typing source ID in callback Since the callback is run only once, the source ID should be set to 0 so that the source ID won t be an invalid value. This avoids a GLib critical on removing the invalid Source ID	f0c5c1d26f47e459dbc5d9140261e313beac472c
	Clear conversation typing source ID in callback Since the callback is run only once, the source ID should be set to 0 so that the source ID won t be an invalid value. This avoids a GLib critical on removing the invalid Source ID	49ce3f5e1b18ee7065fe622f8936a6c1185490a8

Diff:

Revision 2 (+10 -2)

Show changes

libpurple/conversation.c

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```
```
Awesome, thanks for you work!!
```

Status:: Completed

libpurple/conversation.c (Diff revision 1)