Summary

Remove the attention api. It's always been an annoyance and most protocols don't implement it anymore

Review Request #1121 — Created Nov. 2, 2021 and submitted Nov. 22, 2021, 5:59 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Remove the attention api. It's always been an annoyance and most protocols don't implement it anymore

Testing Done

Compiled and connected and xmpp account.

Commits

Summary	ID
Remove the attention api. It's always been an annoyance and most protocols don't implement it anymore	44be2b4d873801822afc9ad13d20d36bd5f30787

Issues

Description	From	Last Updated
Aren't these purple_protocol_*, or were they renamed since 2.x?	QuLogic	Nov. 22, 2021, 5:19 a.m.

Change Summary:

removed files from libpurple-docs.xml

Commits:

	Summary	ID
	Remove the attention api. It's always been an annoyance and most protocols don't implement it anymore	b58cf8ddc6841d6c0a5121a8409b54b8b3997a8a
	Remove the attention api. It's always been an annoyance and most protocols don't implement it anymore	7fe2c77af8bd8902199c07dc6f3d721830d3b8b1

Diff:

Revision 2 (+30 -2628)

Show changes

	ChangeLog.API
	doc/reference/libpurple/libpurple-docs.xml
	libpurple/meson.build
	libpurple/protocols.h
	libpurple/protocols.c
	libpurple/purpleattentiontype.h
	libpurple/purpleattentiontype.c
	libpurple/purpleprotocolattention.h
	14 more

Change Summary:

rebased and fixed conflicts.

Commits:

	Summary	ID
	Remove the attention api. It's always been an annoyance and most protocols don't implement it anymore	7fe2c77af8bd8902199c07dc6f3d721830d3b8b1
	Remove the attention api. It's always been an annoyance and most protocols don't implement it anymore	07926d00a09d255e53af134f5347b0d5f0d19c36

Diff:

Revision 3 (+30 -2628)

Show changes

	ChangeLog.API
	doc/reference/libpurple/libpurple-docs.xml
	libpurple/meson.build
	libpurple/protocols.h
	libpurple/protocols.c
	libpurple/purpleattentiontype.h
	libpurple/purpleattentiontype.c
	libpurple/purpleprotocolattention.h
	14 more

Change Summary:

rebased

Commits:

	Summary	ID
	Remove the attention api. It's always been an annoyance and most protocols don't implement it anymore	07926d00a09d255e53af134f5347b0d5f0d19c36
	Remove the attention api. It's always been an annoyance and most protocols don't implement it anymore	df86f4b0d9e4701b04c3eb4f0aba072b45878270

Diff:

Revision 4 (+30 -2624)

Show changes

	ChangeLog.API
	libpurple/meson.build
	libpurple/protocols.h
	libpurple/protocols.c
	libpurple/purpleattentiontype.h
	libpurple/purpleattentiontype.c
	libpurple/purpleprotocolattention.h
	libpurple/purpleprotocolattention.c
	13 more

Change Summary:

rebased

Commits:

	Summary	ID
	Remove the attention api. It's always been an annoyance and most protocols don't implement it anymore	df86f4b0d9e4701b04c3eb4f0aba072b45878270
	Remove the attention api. It's always been an annoyance and most protocols don't implement it anymore	44be2b4d873801822afc9ad13d20d36bd5f30787

Diff:

Revision 5 (+30 -2624)

Show changes

	ChangeLog.API
	libpurple/meson.build
	libpurple/protocols.h
	libpurple/protocols.c
	libpurple/purpleattentiontype.h
	libpurple/purpleattentiontype.c
	libpurple/purpleprotocolattention.h
	libpurple/purpleprotocolattention.c
	13 more

ChangeLog.API (Diff revision 5)

The issue has been dropped. Show all issues

Aren't these purple_protocol_*, or were they renamed since 2.x?

grim Nov. 21, 2021, 11:58 p.m.

they were named purple_prpl_* in purple2.

$ hg branch
release-2.x.y
$ rg purple_protocol | wc -l
0
$ rg purple_prpl.*attention | wc -l
74

Ship it!

```
Ship It!
```

Status:: Completed