Summary

Remove the Pidgin icon themes which are covered by XDG icon themes now and remove the stock api as that's all that was using it yet.

Review Request #1088 — Created Oct. 21, 2021 and submitted Oct. 29, 2021, 4:45 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Remove the Pidgin icon themes which are covered by XDG icon themes now and remove the stock api as that's all that was using it yet.

Testing Done


Built everything, including the docs and pidgin-pot
Verified that the preferences window still functions properly
Verified that the user list in the conversation window had properly sized icons
Verified all of the status icons were not affected.

Commits

Summary	ID
Remove the Pidgin icon themes which are covered by XDG icon themes now and remove the stock api as that's all that was using it yet.	93712eded6f64783f8ae69344718dde4b2006232

Issues

Description	From	Last Updated
I left this for the size, so wondering what sets the size now?	QuLogic	Oct. 29, 2021, 4:27 a.m.
Remove the whole <child>?	QuLogic	Oct. 29, 2021, 4:27 a.m.

Testing Done:: Built everything, including the docs and pidgin-pot

Verified that the preferences window still functions properly

Verified that the user list in the conversation window had properly sized icons
+
Verified all of the status icons were not affected.

just wanted to add a side note here (mostly for myself) that purple_mkstemp can be removed after this lands.

pidgin/gtkconv.c (Diff revision 1)

The issue has been dropped. Show all issues

I left this for the size, so wondering what sets the size now?

grim Oct. 26, 2021, 4:51 a.m.

nothing, but in my testing the default chosen size was fine.

pidgin/resources/Prefs/prefs.ui (Diff revision 1)
The issue has been resolved. Show all issues
```
Remove the whole <child>?
```

Commits:

	Summary	ID
	Remove the Pidgin icon themes which are covered by XDG icon themes now and remove the stock api as that's all that was using it yet.	0c61848b5221995f6dfb2348901e5e3d5bcab1c9
	Remove the Pidgin icon themes which are covered by XDG icon themes now and remove the stock api as that's all that was using it yet.	93712eded6f64783f8ae69344718dde4b2006232

Diff:

Revision 2 (+84 -2854)

Show changes

	ChangeLog.API
	pidgin/gtkconv.c
	pidgin/gtkicon-theme.h
	pidgin/gtkicon-theme.c
	pidgin/gtkicon-theme-loader.h
	pidgin/gtkicon-theme-loader.c
	pidgin/gtkstatus-icon-theme.h
	pidgin/gtkstatus-icon-theme.c
	7 more

Ship it!

```
Ship It!
```

Status:: Completed

		Built everything, including the docs and pidgin-pot
		Verified that the preferences window still functions properly
		Verified that the user list in the conversation window had properly sized icons
	+	Verified all of the status icons were not affected.