Summary

Automatically generate titles for DMs and GroupDMs

Review Request #3158 — Created May 1, 2024 and submitted May 8, 2024, 8:38 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This is one of the steps in removing PurpleConversation:name. This required a
but of tinkering with property flags and freezing the property notification,
but I think it's all good.

Testing Done

Ran the turtles, ran the tests under valgrind, and opened conversations with the demo protocol plugin and sent some messages.

Commits

Summary	ID
Automatically generate titles for DMs and GroupDMs This is one of the steps in removing PurpleConversation:name. This required a but of tinkering with property flags and freezing the property notification, but I think it's all good.	6fe18ccef8b6ded466633f9080774aacba0ce002

Change Summary:

Fix some typoes and remove purple_conversation_autoset_title and the unnecessary name properties that aren't required now that autoset_title is gone.

Commits:

	Summary	ID
	Automatically generate titles for DMs and GroupDMs This is one of the steps in removing PurpleConversation:name. This required a but of tinkering with property flags and freezing the property notification, but I think it's all good.	532ca5eaff5638897d559cc60d4bcba2ae521d72
	Automatically generate titles for DMs and GroupDMs This is one of the steps in removing PurpleConversation:name. This required a but of tinkering with property flags and freezing the property notification, but I think it's all good.	6fe18ccef8b6ded466633f9080774aacba0ce002

Diff:

Revision 2 (+740 -148)

Show changes

	ChangeLog.API
	libpurple/purpleconversation.h
	libpurple/purpleconversation.c
	libpurple/tests/test_conversation.c
	libpurple/tests/test_conversation_manager.c
	libpurple/tests/test_protocol_conversation.c

Ship it!

```
Self reviewed
```

Review Board 6.0.2