Summary

A bunch of random perl5 tweaks

Review Request #986 — Created Oct. 3, 2021 and submitted Oct. 4, 2021, 5:15 a.m.

Information

Owner

grim

Repository

gplugin/gplugin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

A bunch of random perl5 tweaks

Testing Done

Ran the unit tests.

Commits

Summary	ID
A bunch of random perl5 tweaks	2273bd21ce2d97598ab9feec40657f6a29701032

Issues

Description	From	Last Updated
its	QuLogic	Oct. 4, 2021, 4:48 a.m.
its	QuLogic	Oct. 4, 2021, 4:48 a.m.
You still need this check because error may be set by gplugin_perl_loader_call_gplugin_query, and it's required that error is not set …	QuLogic	Oct. 4, 2021, 4:48 a.m.

perl5/gplugin-perl5-loader.c (Diff revision 1)
Show all issues
```
its
```
perl5/gplugin-perl5-loader.c (Diff revision 1)
Show all issues
```
its
```

perl5/gplugin-perl5-loader.c (Diff revision 1)

Show all issues

You still need this check because error may be set by gplugin_perl_loader_call_gplugin_query, and it's required that error is not set for a call to g_set_error.

grim Oct. 3, 2021, 5:06 a.m.

Ugh I meant to look for that and forgot.. :(

Commits:

	Summary	ID
	A bunch of random perl5 tweaks	7d1f27e075c3a747000374d32a905e01c6e2ff6d
	A bunch of random perl5 tweaks	2273bd21ce2d97598ab9feec40657f6a29701032

Diff:

Revision 2 (+72 -28)

Show changes

	perl5/gplugin-perl5-loader.c
	perl5/gplugin-perl5-plugin.c
	perl5/tests/plugins/basic.pl
	perl5/tests/plugins/dependent.pl
	perl5/tests/plugins/load-exception.pl
	perl5/tests/plugins/load-failed.pl
	perl5/tests/plugins/unload-failed.pl
	perl5/tests/plugins/unload-shutdown.pl

Ship it!

```
Ship It!
```

Review Board 6.0.2

A bunch of random perl5 tweaks

Information

Reviewers

Commits:

Diff:

Status: Closed (submitted)