Summary

Add some additional tests to purple_str_to_time and address their failures.

Review Request #931 — Created Sept. 22, 2021 and submitted Oct. 6, 2021, 9:06 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

release-2.x.y

Bugs

PIDGIN-17552

Depends On

Reviewers

Groups

pidgin

People

Description

Add some additional tests to purple_str_to_time and address their failures.

Testing Done

Ran the unit tests with all sorts of values for TZ and made sure they passed.

Commits

Summary	ID
Add some additional tests to purple_str_to_time and address their failures.	c6e21fe0f8d96833ccfc56d89b5ec16b8e3107c7

Issues

Description	From	Last Updated
This must be duplicated or it might be overwritten by the g_setenv.	QuLogic	Oct. 1, 2021, 9:41 p.m.
we	QuLogic	Oct. 5, 2021, 1:29 a.m.
regardless	QuLogic	Oct. 5, 2021, 1:29 a.m.
will be	QuLogic	Oct. 5, 2021, 1:29 a.m.
will be	QuLogic	Oct. 5, 2021, 1:29 a.m.

Ship it!

```
Ship It!
```

libpurple/tests/test_util.c (Diff revision 1)
Show all issues
```
This must be duplicated or it might be overwritten by the g_setenv.
```
1. grim Sept. 26, 2021, 10:29 p.m.
  nice catch!

Change Summary:

Reworked str_to_time to keep bugs from old version, I'm like 90% certain this right...

Commits:

	Summary	ID
	Add some additional tests to purple_str_to_time and address their failures.	711279f4b012fce51434061bc18bfc66aad4b15d
	Add some additional tests to purple_str_to_time and address their failures.	4b58e52ca86c8b083320089f901419250837ed83

Diff:

Revision 2 (+186 -134)

Show changes

	libpurple/util.c
	libpurple/tests/test_util.c

libpurple/tests/test_util.c (Diff revisions 1 - 2)
Show all issues
```
we
```
libpurple/tests/test_util.c (Diff revisions 1 - 2)
Show all issues
```
regardless
```
libpurple/tests/test_util.c (Diff revisions 1 - 2)
Show all issues
```
will be
```
libpurple/tests/test_util.c (Diff revisions 1 - 2)
Show all issues
```
will be
```

Commits:

	Summary	ID
	Add some additional tests to purple_str_to_time and address their failures.	4b58e52ca86c8b083320089f901419250837ed83
	Add some additional tests to purple_str_to_time and address their failures.	c6e21fe0f8d96833ccfc56d89b5ec16b8e3107c7

Diff:

Revision 3 (+186 -134)

Show changes

	libpurple/util.c
	libpurple/tests/test_util.c

Ship it!

```
Ship It!
```

Review Board 6.0.2

Add some additional tests to purple_str_to_time and address their failures.

Information

Reviewers

Change Summary:

Commits:

Diff:

Commits:

Diff:

Status: Closed (submitted)

libpurple/tests/test_util.c (Diff revision 1)

libpurple/tests/test_util.c (Diff revisions 1 - 2)

libpurple/tests/test_util.c (Diff revisions 1 - 2)

libpurple/tests/test_util.c (Diff revisions 1 - 2)