Summary

Fix an assert in purple_markup_html_to_xhtml

Review Request #921 — Created Sept. 13, 2021 and submitted Sept. 15, 2021, 1:24 p.m.

Owner

Repository

pidgin/pidgin

Branch

release-2.x.y

Bugs

Depends On

Groups

People

Description

While g_string_free is NULL-safe, the assert for passing it in breaks
ossfuzz. This can happen if there is no src= in the img as expected.

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=35029

Testing Done

Ran the test case from the bug against fuzz_html_to_xhtml

Commits

Summary	ID
Fix an assert in purple_markup_html_to_xhtml While `g_string_free` is NULL-safe, the assert for passing it in breaks ossfuzz. This can happen if there is no `src=` in the `img` as expected. Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=35029	2b4c1ad76f9be1c1074923d25b68a4a3c5148657

Ship it!