Summary

Change loader registration to work on an instance rather than a GType

Review Request #899 — Created Aug. 16, 2021 and submitted Sept. 24, 2021, 4:31 a.m.

Information

Owner

grim

Repository

gplugin/gplugin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Change loader registration to work on an instance rather than a GType

Testing Done

Ran the unit tests in valgrind and verifed there was no new memory leaks in the loader registration. Right now the plugins themselfs leak a reference, but I'll be cleaning that up shortly.

Commits

Summary	ID
Change loader registration to work on an instance rather than a GType	3038b542c0e0adc0168a96dcf558881a20895088

Issues

Description	From	Last Updated
Should this not use gplugin_native_loader_new?	QuLogic	Sept. 13, 2021, 7:36 a.m.
"So we'll" is doubled	QuLogic	Sept. 13, 2021, 7:40 p.m.
Shouldn't this be !g_str_equal?	QuLogic	Sept. 13, 2021, 7:39 a.m.
instance	QuLogic	Sept. 13, 2021, 7:40 p.m.

This seems fine, but I wonder what precipitated the change?

grim Sept. 11, 2021, 4:11 p.m.

just trying to standardize on instances like we have in pidgin rather than types.

gplugin/gplugin-manager.c (Diff revision 1)

Show all issues

Should this not use gplugin_native_loader_new?

gplugin/gplugin-manager.c (Diff revision 1)
Show all issues
```
Shouldn't this be !g_str_equal?
```

Commits:

	Summary	ID
	Change loader registration to work on an instance rather than a GType	c5fa7da712f1eda1c98d6affd67522435d0a0a5e
	Change loader registration to work on an instance rather than a GType	a6962424d5f1916294ae2fddca73846f343ea2f9

Diff:

Revision 2 (+482 -314)

Show changes

	gplugin/gplugin-manager.h
	gplugin/gplugin-manager.c
	gplugin/gplugin-native-loader.h
	gplugin/gplugin-native-loader.c
	gplugin/tests/test-loader-registration.c
	lua/gplugin-lua-core.c
	lua/gplugin-lua-loader.h
	lua/gplugin-lua-loader.c
	9 more

gplugin/gplugin-manager.c (Diff revisions 1 - 2)
Show all issues
```
"So we'll" is doubled
```
gplugin/gplugin-native-loader.c (Diff revisions 1 - 2)
Show all issues
```
instance
```

Commits:

	Summary	ID
	Change loader registration to work on an instance rather than a GType	a6962424d5f1916294ae2fddca73846f343ea2f9
	Change loader registration to work on an instance rather than a GType	3038b542c0e0adc0168a96dcf558881a20895088

Diff:

Revision 3 (+480 -314)

Show changes

	gplugin/gplugin-manager.h
	gplugin/gplugin-manager.c
	gplugin/gplugin-native-loader.h
	gplugin/gplugin-native-loader.c
	gplugin/tests/test-loader-registration.c
	lua/gplugin-lua-core.c
	lua/gplugin-lua-loader.h
	lua/gplugin-lua-loader.c
	9 more

Ship it!

```
Ship It!
```

Review Board 6.0.2

Change loader registration to work on an instance rather than a GType

Information

Reviewers

Commits:

Diff:

Commits:

Diff:

Status: Closed (submitted)