Change loader registration to work on an instance rather than a GType

Review Request #899 — Created Aug. 16, 2021 and updated

grim
gplugin/gplugin
default
pidgin
Change loader registration to work on an instance rather than a GType

Ran the unit tests in valgrind and verifed there was no new memory leaks in the loader registration. Right now the plugins themselfs leak a reference, but I'll be cleaning that up shortly.

Summary
Change loader registration to work on an instance rather than a GType
Description From Last Updated

Should this not use gplugin_native_loader_new?

QuLogicQuLogic

"So we'll" is doubled

QuLogicQuLogic

Shouldn't this be !g_str_equal?

QuLogicQuLogic

instance

QuLogicQuLogic
QuLogic
  1. 
      
  2. This seems fine, but I wonder what precipitated the change?

    1. just trying to standardize on instances like we have in pidgin rather than types.

  3. gplugin/gplugin-manager.c (Diff revision 1)
     
     
     
     
     
     
     

    Should this not use gplugin_native_loader_new?

  4. gplugin/gplugin-manager.c (Diff revision 1)
     
     

    Shouldn't this be !g_str_equal?

  5. 
      
grim
QuLogic
  1. 
      
  2. gplugin/gplugin-manager.c (Diff revisions 1 - 2)
     
     
     

    "So we'll" is doubled

  3. gplugin/gplugin-native-loader.c (Diff revisions 1 - 2)
     
     

    instance

  4. 
      
grim
Review request changed

Commits:

Summary
-
Change loader registration to work on an instance rather than a GType
+
Change loader registration to work on an instance rather than a GType

Diff:

Revision 3 (+480 -314)

Show changes

QuLogic
  1. Ship It!
  2. 
      
Loading...