Remove the usage of GtkStock from gtknotify.c

Review Request #892 — Created Aug. 10, 2021 and submitted

grim
pidgin/pidgin
default
pidgin
Remove the usage of GtkStock from gtknotify.c

Compile only.

Summary
Remove the usage of GtkStock from gtknotify.c
jrchamp
  1. The before and after strings matched. The only difference seems to be N_() and _(), which seems like an improvement if I correctly understood the documentation (something about not needing to call gettext() manually).

    1. Ignore me, I mistook the #define and the stock_items. I guess this removes the stock images? It does at least match the "Add" button.

    2. The GtkStock API is deprecated and by default it doesn't even show the icons in buttons, menus, etc. So all we're really doing here is removing it from our code since it's already removed from the default user experience and isn't really the way they expect Gtk Applications to work any more (for better or worse).

  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...