Start embedding our icon theme by starting with the status icons used in PidginPresenceIcon

Review Request #885 — Created Aug. 7, 2021 and submitted

Information

pidgin/pidgin
default

Reviewers

Start embedding our icon theme by starting with the status icons used in PidginPresenceIcon

Modified an icon and verified it was being used (and of course reverted).

Summary ID
Start embedding our icon theme by starting with the status icons used in PidginPresenceIcon
de17ce0f12bf5e5fc714e8b8103bc20eae48000f
Description From Last Updated

Space after comma. Also, GtkApplication (I think we use that?) may already automatically add a path based on the application …

QuLogicQuLogic
grim
grim
QuLogic
  1. 
      
  2. pidgin/libpidgin.c (Diff revision 1)
     
     

    Space after comma.

    Also, GtkApplication (I think we use that?) may already automatically add a path based on the application name (which may be /im/pidgin/Pidgin3 instead.)

    1. crap you're right, but since we're currently wrong, I'll update this review request to set the resource-base-path to the improper one, then after this is merged, we can update the resource file to /im/pidgin/Pidgin3 and then update all of the template widgets and everything else that we'll need to.

  3. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...