Add a .mailmap file

 






 

 


  Review Request #875
  —
  Created Aug. 4, 2021 and submitted 

 


















 

  

   Information

  





 
 

  grim
 









 
 

  pidgin/pidgin
 









 
 

  default
 









 
 

  
 









 
 

  
 









 
 

  59cc6465c3a6
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
Add a .mailmap file that can be used via the mailmap functio in mercurial templates to map author names/email addresses.


Some of these aren't matching right yet, but at least we have the dupes now and don't have to search for them again.


Also, I did a lot of guess work here on proper emails and usually deferred to gmail over a custom domain.

 








  


 
 

  
Lots of shell magic involving hg log -T '{mailmap(author)}\n' and without the mailmap.

 







 









 





  








 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
The first line's "empty email" mapping and the fourth line's "no email" seem like invalid values.

      		
      
       jrchampjrchamp
      
      
       
      
     




     

      
       
       
It doesn't look like Mercurial's mapping parser will allow fixing this "missing end angle bracket" value because it fails the …

      		
      
       jrchampjrchamp
      
      
       
      
     


    
   

  

 







 






  

 








 














 





 

  

   




jrchamp




   

   







  

 



 

  


   

   

    
 
jrchamp


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Here's the source of the parser: https://www.mercurial-scm.org/repo/hg/file/tip/mercurial/utils/stringutil.py#l529
      
 
      

      2. 


 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      .mailmap
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    The first line's "empty email" mapping and the fourth line's "no email" seem like invalid values.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Yep, see the following from the description
      

      | Some of these aren't matching right yet, but at least we have the dupes now and don't have to search for them again.
      
 
      

      2. 


 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      .mailmap
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    It doesn't look like Mercurial's mapping parser will allow fixing this "missing end angle bracket" value because it fails the "isauthorwellformed()" test.
    

    Instead, this dedpulication should work:
    
dequis dx@dxzone.com.ar dx dx@dxzone.com.ar
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      are you including <>'s here? If so can you mark them as code so I can see exactly what you're suggesting?
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      I was going for this:
      
dequis <dx@dxzone.com.ar> dx <dx@dxzone.com.ar>
      

      It looks like you've already included that line in the latest revision.
      
 
      

      3. 


 
    


    

 
    

    4. 




  4. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  

 
















 



 

  

   




grim




   

   

  

 



 















 





 

  

   




jrchamp




   

   







  

 



 

  


   

   

    
 
jrchamp


    
   


  

  

  



    




  1. 
 
    
  
    
   
    This is a good set of changes for now. Unfortunately, either the "official" mailmap format - or Mercurial's implementation of it - is not flexible enough to fully address the needs of the existing author entries in the repository. On a positive note, we're forward compatible if Mercurial loosens the requirements a bit.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




grim




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...