Summary

Fix an out of bounds write in purple_markup_linkify.

Review Request #781 — Created June 23, 2021 and submitted July 10, 2021, 4:32 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

release-2.x.y

Bugs

Depends On

Commit

d284f5089e0c

Groups

People

Description

This was found by Thomas Roth <code@stacksmashing.net>, Dominik Maier
<mail@dmnk.co>, and Fabian Freyer <mail@fabianfreyer.de>.

Testing Done

Compiled and ran the purple_markup_linkify_fuzzer from the google oss-fuzz project to verify the fix.

Issues

Description	From	Last Updated
Bounds should be checked before the dereference. Can you add the braces too?	QuLogic	June 24, 2021, 9:03 a.m.

libpurple/util.c (Diff revision 1)

The issue has been resolved. Show all issues

Bounds should be checked before the dereference.

Can you add the braces too?

Sure this was just the raw patch.. Also I forgot that I used the fuzzer they provided which I'll add after 760 is merged.

Change Summary:

brackets and avoid an oob read..

Commit:

2f3f7a682288

d284f5089e0c

Diff:

Ship it!

Ship it!