Add notes about making the dev server accessible from other nodes on the network and fix a typo I caught in the process.

Review Request #662 — Created May 23, 2021 and submitted

rekkanoryo
pidgin/nest
default
b2382d85b02c
pidgin-www
Add notes about making the dev server accessible from other nodes on the network and fix a typo I caught in the process.

Verified that added documentation works as expected.

grim
  1. 
      
  2. readme.md (Diff revision 1)
     
     

    I assume you're not binding to 0.0.0.0 here because of the baseURL?

    1. Yeah. You could totally bind to 0.0.0.0 but with the baseURL needed to make everything work right, the instructions are clearer using the same address for both. As an alternative you could bind to 0.0.0.0 and have the baseURL be a hostname that resolves to an ip address of the machine you're running the dev server on, but I was aiming to keep the instructions simple.

    2. Okay that's fine, I just wanted to make sure that was the reason :-D

  3. 
      
grim
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...