Summary

Convert credentials page to use HdyPreferencesGroup and a list box.

Review Request #644 — Created May 7, 2021 and submitted May 12, 2021, 10:37 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Commit

b6cec6205b03

Reviewers

Groups

pidgin

People

Description


Convert credentials page to use HdyPreferencesGroup and a list box.
Add widget for displaying a credential provider in a list box.
Convert PidginCredentialsPage into HdyPreferencesPage.

Testing Done

Opened Preferences, switch to Credentials page, and see/toggle selected provider.

Files

Issues

Description	From	Last Updated
This should probably have a g_return_val_if_fail(PIDGIN_IS_CREDENTIAL_PROVIDER_ROW(row), NULL);	grim	May 12, 2021, 10:36 a.m.
g_return_val_if_fail	grim	May 12, 2021, 10:36 a.m.
g_return_if_fail	grim	May 12, 2021, 10:36 a.m.

So my only concern about the setup is that it seems like you can activate a provider without configuring it. Maybe that's okay, as most providers should "function" but return errors.
That said, maybe provider's need a config_is_valid function or something. I dunno I'm just thinking out loud here.

pidgin/pidgincredentialproviderrow.c (Diff revision 1)

Show all issues

This should probably have a g_return_val_if_fail(PIDGIN_IS_CREDENTIAL_PROVIDER_ROW(row), NULL);

pidgin/pidgincredentialproviderrow.c (Diff revision 1)
Show all issues
```
g_return_val_if_fail
```
pidgin/pidgincredentialproviderrow.c (Diff revision 1)
Show all issues
```
g_return_if_fail
```

Change Summary:

Add g_return_* calls to accessors.

Diff:

Revision 2 (+498 -140)

Show changes

	meson.build
	doc/reference/pidgin/pidgin-docs.xml
	pidgin/meson.build
	pidgin/pidginapplication.c
	pidgin/pidgincredentialproviderrow.h
	pidgin/pidgincredentialproviderrow.c
	pidgin/pidgincredentialspage.h
	pidgin/pidgincredentialspage.c
	5 more

Ship it!

```
Ship It!
```

Review Board 6.0.2

Convert credentials page to use HdyPreferencesGroup and a list box.

Information

Reviewers

Change Summary:

Diff:

Status: Closed (submitted)