Convert credentials page to use HdyPreferencesGroup and a list box.

Review Request #644 — Created May 7, 2021 and submitted

QuLogic
pidgin/pidgin
default
b6cec6205b03
pidgin
  • Convert credentials page to use HdyPreferencesGroup and a list box.
  • Add widget for displaying a credential provider in a list box.
  • Convert PidginCredentialsPage into HdyPreferencesPage.

Opened Preferences, switch to Credentials page, and see/toggle selected provider.


Description From Last Updated

This should probably have a g_return_val_if_fail(PIDGIN_IS_CREDENTIAL_PROVIDER_ROW(row), NULL);

grimgrim

g_return_val_if_fail

grimgrim

g_return_if_fail

grimgrim
grim
  1. 
      
  2. So my only concern about the setup is that it seems like you can activate a provider without configuring it. Maybe that's okay, as most providers should "function" but return errors.

    That said, maybe provider's need a config_is_valid function or something. I dunno I'm just thinking out loud here.

  3. pidgin/pidgincredentialproviderrow.c (Diff revision 1)
     
     

    This should probably have a g_return_val_if_fail(PIDGIN_IS_CREDENTIAL_PROVIDER_ROW(row), NULL);

  4. pidgin/pidgincredentialproviderrow.c (Diff revision 1)
     
     

    g_return_val_if_fail

  5. pidgin/pidgincredentialproviderrow.c (Diff revision 1)
     
     

    g_return_if_fail

  6. 
      
QuLogic
grim
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...