Summary

Use the G_DECLARE_*_TYPE macros for JabberProtocol and XMPPProtocol

Review Request #618 — Created April 15, 2021 and submitted April 20, 2021, 1:56 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Commit

11fe3cc385d0

Reviewers

Groups

pidgin

People

Description

Use the G_DECLARE_*_TYPE macros for JabberProtocol and XMPPProtocol

Testing Done

Connected an XMPP account.

Files

Issues

Description	From	Last Updated
So as we were discussing in the other review, you might want to test this on out on Windows? That …	QuLogic	April 18, 2021, 3:38 a.m.
Remove _get_type?	QuLogic	April 18, 2021, 3:38 a.m.
Remove _get_type?	QuLogic	April 18, 2021, 3:38 a.m.

libpurple/protocols/jabber/jabber.h (Diff revision 1)
Show all issues
```
Remove _get_type?
```
libpurple/protocols/jabber/xmpp.h (Diff revision 1)
Show all issues
```
Remove _get_type?
```

Change Summary:

Remove the get_type prototypes

Commit:

-	b71e7e1efb60
+	11fe3cc385d0

Diff:

Revision 2 (+13 -33)

Show changes

	libpurple/protocols/jabber/jabber.h
	libpurple/protocols/jabber/xmpp.h
	libpurple/protocols/jabber/xmpp.c

Show all issues

So as we were discussing in the other review, you might want to test this on out on Windows? That uses the opposite default visibility to Linux, and would hide _get_type.

grim April 16, 2021, 8:21 a.m.

Would you consider being able to connect an xmpp account enough of test?

grim April 16, 2021, 9:07 a.m.

See the attached screen shot.  But again, no one else needs to call the get_type function in this case. This may be an issue for stuff like carbons and other plugins that extend prpls, but they can also work around this by querying the type system directly by using g_type_from_name. Regardless of this function, it's affect is the type is registered in the type system which is available to everyone.

Added Files:

Ship it!

```
Ship It!
```