Use the G_DECLARE_*_TYPE macros for JabberProtocol and XMPPProtocol

Review Request #618 — Created April 14, 2021 and submitted

grim
pidgin/pidgin
default
11fe3cc385d0
pidgin
Use the G_DECLARE_*_TYPE macros for JabberProtocol and XMPPProtocol

Connected an XMPP account.


Description From Last Updated

So as we were discussing in the other review, you might want to test this on out on Windows? That ...

QuLogicQuLogic

Remove _get_type?

QuLogicQuLogic

Remove _get_type?

QuLogicQuLogic
QuLogic
  1. 
      
  2. libpurple/protocols/jabber/jabber.h (Diff revision 1)
     
     

    Remove _get_type?

  3. libpurple/protocols/jabber/xmpp.h (Diff revision 1)
     
     

    Remove _get_type?

  4. 
      
grim
QuLogic
  1. 
      
  2. So as we were discussing in the other review, you might want to test this on out on Windows? That uses the opposite default visibility to Linux, and would hide _get_type.

    1. Would you consider being able to connect an xmpp account enough of test?

    2. See the attached screen shot. But again, no one else needs to call the get_type function in this case. This may be an issue for stuff like carbons and other plugins that extend prpls, but they can also work around this by querying the type system directly by using g_type_from_name. Regardless of this function, it's affect is the type is registered in the type system which is available to everyone.

  3. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
rekkanoryo
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...