Use G_DECLARE_FINAL_TYPE for the IRCProtocol

Review Request #616 — Created April 14, 2021 and submitted

grim
pidgin/pidgin
default
c302bc3ab0a3
pidgin

Use G_DECLARE_FINAL_TYPE for the IRCProtocol

Connected an IRC account.

Description From Last Updated

Don't you need G_MODULE_EXPORT here?

QuLogicQuLogic
grim
QuLogic
  1. 
      
  2. libpurple/protocols/irc/irc.h (Diff revision 1)
     
     

    Don't you need G_MODULE_EXPORT here?

    1. Why would we?

    2. It used to be there on line 133.

    3. Sure, but even then, the plugin itself registered the type in the type system by calling it even when the protocols were registered by their GType, but now that they're registered by instance, the GType registered via the objection instantiation which then gets registered in the plugin manager. So tl;dr.. the only thing calling it is the plugin itself. Now it might somehow be needed for xmpp for stuff like plugins that looks up the prpl, but we'll need to test that separately.

  3. 
      
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...